Review main Merged

83206[TASK] Throw LogicException in HashService when required parameter is empty

Torben Hansen CR +2 V +2 Easy +2 −29 updated 03/04/24, 22:02

Commit message

The `hmac` function in the `HashService` class should not throw a
custom `EmptyAdditionalSecretException` when the `$additionalSecret`
parameter is an empty string. Instead, a top level exception should
be used, as the issue is caused from incorrect parameter usage by
the  developer.

This change replaces the `EmptyAdditionalSecretException` with a
`LogicException` to better indicate the misuse of the method's
parameters.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Torben Hansen uploaded patch set 1 03/04/24, 20:37

  2. core-ci voted on patch set 1 V +1 03/04/24, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53907

  3. Oliver Klee voted on patch set 1 CR +1 V +1 03/04/24, 20:51

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 03/04/24, 22:02

  5. Christian Kuhn merged patch set 2 03/04/24, 22:02