Review main Merged

83207[TASK] Remove jQuery from @typo3/backend/viewport/content-container

Andreas Nedbal CR +2 V +2 Easy +4 −9 updated 03/05/24, 10:47

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Nedbal uploaded patch set 1 03/05/24, 08:52

  2. core-ci voted on patch set 1 V +1 03/05/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53923

  3. Andreas Kienast commented on patch set 1 03/05/24, 09:06

    content-container.ts:83

    I know it was broken before, but I think we should fix this to `HTMLElement|null`.
  4. Andreas Kienast uploaded patch set 2 V +1 03/05/24, 09:08

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 03/05/24, 09:08

  6. Andreas Kienast commented on patch set 2 03/05/24, 09:08

    content-container.ts:83 Reply

    Done
  7. core-ci voted on patch set 2 V +1 03/05/24, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53925

  8. Benni Mack voted on patch set 2 CR +1 V +1 03/05/24, 10:45

  9. Andreas Nedbal voted on patch set 2 CR +2 V +2 03/05/24, 10:47

  10. Andreas Nedbal merged patch set 3 03/05/24, 10:47