83209[FEATURE] Add new expression methods to ExpressionBuilder
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php20+455 −1
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php2+2 −0
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst14new+704 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderCastInt.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderCastVarchar.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderConcat.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php24+721 −0
Review log 2339
Show 714 earlier messages
-
Stefan Bürk uploaded patch set 1 03/05/24, 09:32
-
core-ci voted on patch set 1 V +1 03/05/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53926
-
Stefan Bürk uploaded patch set 2
V +103/05/24, 12:08 -
core-ci voted on patch set 2 V -1 03/05/24, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53940
-
Stefan Bürk uploaded patch set 3
V -103/05/24, 12:28 -
core-ci voted on patch set 3 V +1 03/05/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53941
-
Stefan Bürk uploaded patch set 4
V +103/05/24, 16:10 -
core-ci voted on patch set 4 V +1 03/05/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53966
-
Stefan Bürk uploaded patch set 5
V +103/06/24, 14:36 -
core-ci voted on patch set 5 V +1 03/06/24, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54042
-
Stefan Bürk uploaded patch set 6
V +103/06/24, 15:34 -
core-ci voted on patch set 6 V +1 03/06/24, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54047
-
Stefan Bürk uploaded patch set 7
V +103/06/24, 16:09 -
core-ci voted on patch set 7 V +1 03/06/24, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54049
-
Stefan Bürk uploaded patch set 8
V +103/06/24, 18:44 -
Stefan Bürk rebased onto patch set 9 03/06/24, 18:44
-
core-ci voted on patch set 9 V -1 03/06/24, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54066
-
core-ci voted on patch set 8 V +1 03/06/24, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54065
-
Chris Müller uploaded patch set 10
V -103/06/24, 19:30 -
core-ci voted on patch set 10 V +1 03/06/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54071
-
Stefan Bürk uploaded patch set 11
V +103/07/24, 18:20 -
Stefan Bürk updated the commit message in patch set 12 03/07/24, 18:21
-
core-ci voted on patch set 11 V +1 03/07/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54169
-
Stefan Bürk uploaded patch set 13 03/07/24, 18:29
-
core-ci voted on patch set 12 V +1 03/07/24, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54171
-
core-ci voted on patch set 13 V +1 03/07/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54177
-
core-ci commented on patch set 13 03/07/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54181
-
Marvin Buchmann commented on patch set 13 03/07/24, 19:32
ExpressionBuilder.php:572therefor -> thereforeExpressionBuilder.php:584a integer -> an integerExpressionBuilder.php:617a error -> an errorExpressionBuilder.php:617a invalid type -> an invalid typeExpressionBuilder.php:665a SQL -> an SQLExpressionBuilder.php:704$numberOfRepeates -> $numberOfRepeatsExpressionBuilder.php:836a integer -> an integerExpressionBuilder.php:897a integer -> an integerExpressionBuilder.php:1117cutts -> cutsQueryBuilder.php:1163a expression -> an expressionFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:16since -> forFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:21a alias -> an aliasFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:63a argument -> an argumentFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:124Unquoted value or expression part to concatenated with the other parts -> Unquoted values or expression parts to concatenate with each otherFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:184prefered -> preferredFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:240prefered -> preferredFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:575complexer -> more complexExpressionBuilderTest.php:984concetination -> concatenationExpressionBuilderTest.php:1112double point -> colonExpressionBuilderTest.php:1118time -> times (all occurences in this method with a greater value than 1)ExpressionBuilderTest.php:1277one spaces -> one space (all occurences in this method with 'one')ExpressionBuilderTest.php:1417to -> tooExpressionBuilderTest.php:1423to -> tooExpressionBuilderTest.php:1458to -> tooExpressionBuilderTest.php:1464to -> tooExpressionBuilderTest.php:1500to -> tooExpressionBuilderTest.php:1506to -> tooExpressionBuilderTest.php:1562to -> tooExpressionBuilderTest.php:1568to -> too -
Christian Kuhn uploaded patch set 14
V +103/07/24, 21:02 -
Christian Kuhn commented on patch set 14 03/07/24, 21:09
ExpressionBuilder.php:514ReplyDoneExpressionBuilder.php:572ReplyDoneExpressionBuilder.php:584ReplyDoneExpressionBuilder.php:617ReplyDoneExpressionBuilder.php:617ReplyDoneExpressionBuilder.php:665ReplyDoneExpressionBuilder.php:704ReplyDoneExpressionBuilder.php:836ReplyDoneExpressionBuilder.php:897ReplyDoneExpressionBuilder.php:1117ReplyDoneQueryBuilder.php:1163ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:16ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:21ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:63ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:124ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:184ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:240ReplyDoneFeature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:575ReplyDoneExpressionBuilderTest.php:984ReplyDoneExpressionBuilderTest.php:1112ReplyDoneExpressionBuilderTest.php:1118ReplyDoneExpressionBuilderTest.php:1277ReplyDoneExpressionBuilderTest.php:1417ReplyDoneExpressionBuilderTest.php:1423ReplyDoneExpressionBuilderTest.php:1458ReplyDoneExpressionBuilderTest.php:1464ReplyDoneExpressionBuilderTest.php:1500ReplyDoneExpressionBuilderTest.php:1506ReplyDoneExpressionBuilderTest.php:1562ReplyDoneExpressionBuilderTest.php:1568ReplyDone -
Christian Kuhn uploaded patch set 15 03/07/24, 21:09
-
Christian Kuhn voted on patch set 15 CR +1 V +1 03/07/24, 21:09
-
core-ci voted on patch set 14 V +1 03/07/24, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54195
-
core-ci voted on patch set 15 V +1 03/07/24, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54197
-
Oliver Klee voted on patch set 15 V +1 03/07/24, 23:22
-
Benni Mack voted on patch set 15 CR +1 V +1 03/08/24, 06:56
-
Anja Leichsenring voted on patch set 15 CR +1 V +1 03/08/24, 08:25
-
Stefan Bürk voted on patch set 15 CR +2 V +2 03/08/24, 08:34
-
Stefan Bürk merged patch set 16 03/08/24, 08:34
ExpressionBuilder.php:514