Review main Merged

83212[TASK] Fix accessibility issues in topbar and menu

Frank Nägler CR +2 V +2 Easy +27 −20 updated 03/05/24, 17:45

Commit message

To increase the accessibility of the backend, some issues in the
topbar and menu were fixed.
This patch is one pre-patch to make the accessibility CI test
possible soon.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1924

  1. Frank Nägler uploaded patch set 1 03/05/24, 13:15

  2. core-ci voted on patch set 1 V +1 03/05/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53942

  3. Frank Nägler uploaded patch set 2 V +1 03/05/24, 13:52

  4. core-ci voted on patch set 2 V +1 03/05/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53947

  5. Benjamin Kott voted on patch set 2 CR +1 V +1 03/05/24, 14:20

  6. Oli Bartsch commented on patch set 2 03/05/24, 14:23

    locallang.xlf:10

    Any reason not starting with a capital letter?
  7. Frank Nägler commented on patch set 2 03/05/24, 14:27

    locallang.xlf:10 Reply

    Yes, it is used as addition to link text, example: "TYPO3 Documentation (opens in a new window)"
  8. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 03/05/24, 14:30

  9. Oli Bartsch commented on patch set 3 03/05/24, 14:33

    locallang.xlf:10 Reply

    Acknowledged
  10. core-ci voted on patch set 3 V +1 03/05/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53949

  11. Benjamin Kott voted on patch set 3 CR +1 V +1 03/05/24, 14:42

  12. Benjamin Franzke commented on patch set 3 CR -1 03/05/24, 15:45

    Will, merge, but blocked until https://review.typo3.org/c/Packages/TYPO3.CMS/+/83233 is merged (to avoid conflicts)
  13. Andreas Kienast commented on patch set 3 CR -1 03/05/24, 15:52

    Some `h3 class="dropdown-headline` are left, will update
  14. Andreas Kienast uploaded patch set 4 CR +1 V +1 03/05/24, 15:53

  15. Andreas Kienast voted on patch set 4 CR +1 V +1 03/05/24, 15:53

  16. Benjamin Franzke voted on patch set 4 CR -1 03/05/24, 15:54

  17. core-ci voted on patch set 4 V +1 03/05/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53963

  18. Benjamin Franzke uploaded patch set 5 CR +1 V +1 03/05/24, 17:06

  19. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/05/24, 17:07

  20. Benjamin Franzke commented on patch set 5 03/05/24, 17:09

    I've additionally documented the fixed issues in https://forge.typo3.org/issues/103284 They were found with patchset 8 of https://review.typo3.org/c/Packages/TYPO3.CMS/+/80557/8
  21. core-ci voted on patch set 5 V +1 03/05/24, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53971

  22. Andreas Kienast voted on patch set 5 CR +1 V +1 03/05/24, 17:41

  23. Benjamin Franzke voted on patch set 5 CR +2 V +2 03/05/24, 17:44

  24. Benjamin Franzke merged patch set 6 03/05/24, 17:45