83212[TASK] Fix accessibility issues in topbar and menu
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+1 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf3+3 −0
- typo3/sysext/backend/Resources/Private/Partials/Backend/ModuleMenu.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItemDropDown.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html+3 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemDropDown.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemEditForm.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/SystemInformationDropDown.html+4 −3
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html+1 −1
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/DropDown.html+3 −3
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.html+1 −1
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarItems/DropDown.html+1 −1
Review log 1924
-
Frank Nägler uploaded patch set 1 03/05/24, 13:15
-
core-ci voted on patch set 1 V +1 03/05/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53942
-
Frank Nägler uploaded patch set 2
V +103/05/24, 13:52 -
core-ci voted on patch set 2 V +1 03/05/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53947
-
Benjamin Kott voted on patch set 2 CR +1 V +1 03/05/24, 14:20
-
Oli Bartsch commented on patch set 2 03/05/24, 14:23
-
Frank Nägler commented on patch set 2 03/05/24, 14:27
locallang.xlf:10ReplyYes, it is used as addition to link text, example: "TYPO3 Documentation (opens in a new window)" -
Benjamin Franzke updated the commit message in patch set 3
CR +1V +103/05/24, 14:30 -
Oli Bartsch commented on patch set 3 03/05/24, 14:33
locallang.xlf:10ReplyAcknowledged -
core-ci voted on patch set 3 V +1 03/05/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53949
-
Benjamin Kott voted on patch set 3 CR +1 V +1 03/05/24, 14:42
-
Benjamin Franzke commented on patch set 3 CR -1 03/05/24, 15:45
Will, merge, but blocked until https://review.typo3.org/c/Packages/TYPO3.CMS/+/83233 is merged (to avoid conflicts) -
Andreas Kienast commented on patch set 3 CR -1 03/05/24, 15:52
Some `h3 class="dropdown-headline` are left, will update -
Andreas Kienast uploaded patch set 4
CR +1V +103/05/24, 15:53 -
Andreas Kienast voted on patch set 4 CR +1 V +1 03/05/24, 15:53
-
Benjamin Franzke voted on patch set 4 CR -1 03/05/24, 15:54
-
core-ci voted on patch set 4 V +1 03/05/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53963
-
Benjamin Franzke uploaded patch set 5
CR +1V +103/05/24, 17:06 -
Benjamin Franzke voted on patch set 5 CR +1 V +1 03/05/24, 17:07
-
Benjamin Franzke commented on patch set 5 03/05/24, 17:09
I've additionally documented the fixed issues in https://forge.typo3.org/issues/103284 They were found with patchset 8 of https://review.typo3.org/c/Packages/TYPO3.CMS/+/80557/8 -
core-ci voted on patch set 5 V +1 03/05/24, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53971
-
Andreas Kienast voted on patch set 5 CR +1 V +1 03/05/24, 17:41
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 03/05/24, 17:44
-
Benjamin Franzke merged patch set 6 03/05/24, 17:45
locallang.xlf:10