Review main Merged

83213[TASK] Respect alt text in backend thumbnails

Willi Wehmeier CR +2 V +2 Easy +1 −1 updated 03/05/24, 14:33

Commit message

The thumbCode method in the BackendUtility sets
the filename as the alt text for images. That's
why the backend representation of content elements
like textmedia doesn't respect any set alternative
text, whether it's set in the file_reference or
the sys_file record itself.

This change uses the alternative text and only
sets the filename as a fallback if there's no
alternative text provided for the file.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Kevin Appelt +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Kevin Appelt +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Willi Wehmeier uploaded patch set 1 03/05/24, 13:40

  2. Willi Wehmeier uploaded patch set 2 03/05/24, 13:42

  3. core-ci voted on patch set 1 V +1 03/05/24, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53944

  4. core-ci voted on patch set 2 V +1 03/05/24, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53945

  5. Simon Schaufelberger voted on patch set 2 CR +1 03/05/24, 13:56

  6. Jasmina Ließmann voted on patch set 2 CR +1 V +1 03/05/24, 13:58

  7. Kevin Appelt voted on patch set 2 CR +1 V +1 03/05/24, 14:11

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 03/05/24, 14:33

  9. Oli Bartsch merged patch set 3 03/05/24, 14:33