Review main Merged

83216[TASK] Remove jQuery from workspaces record information

Andreas Nedbal CR +2 V +2 Hard +179 −135 updated 03/07/24, 17:54

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1318

  1. Andreas Nedbal uploaded patch set 1 03/05/24, 15:05

  2. core-ci voted on patch set 1 V -1 03/05/24, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53955

  3. Andreas Nedbal uploaded patch set 2 V -1 03/05/24, 15:13

  4. core-ci voted on patch set 2 V +1 03/05/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53956

  5. Andreas Kienast commented on patch set 2 CR -1 03/05/24, 15:40

    backend.ts:80

    The `*-view` components should now be imported in the new component.

    record-information.ts:53

    I think we can use the `lll()` helper instead.
  6. Andreas Nedbal uploaded patch set 3 CR -1 V +1 03/05/24, 16:02

  7. Andreas Nedbal commented on patch set 3 03/05/24, 16:04

    backend.ts:80 Reply

    Done

    record-information.ts:53 Reply

    This (sadly) has to be done because we are switching contexts with this component being used in a modal. lll() just accesses TYPO3.lang, which only contains the top window locales, not the module specific ones.
  8. core-ci voted on patch set 3 V +1 03/05/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53965

  9. Andreas Kienast commented on patch set 3 03/05/24, 16:14

    record-information.ts:53 Reply

    Acknowledged
  10. Andreas Nedbal rebased onto patch set 4 V +1 03/07/24, 11:31

    The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  11. Andreas Nedbal uploaded patch set 5 03/07/24, 11:33

  12. Andreas Nedbal marked it ready for review 03/07/24, 11:33

  13. core-ci voted on patch set 5 V +1 03/07/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54135

  14. core-ci voted on patch set 4 V -1 03/07/24, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54134

  15. Andreas Kienast voted on patch set 5 CR +1 V +1 03/07/24, 17:03

  16. Benni Mack voted on patch set 5 CR +1 V +1 03/07/24, 17:20

  17. Andreas Nedbal voted on patch set 5 CR +2 V +2 03/07/24, 17:54

  18. Andreas Nedbal merged patch set 6 03/07/24, 17:54