83216[TASK] Remove jQuery from workspaces record information
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
Review log 1318
-
Andreas Nedbal uploaded patch set 1 03/05/24, 15:05
-
core-ci voted on patch set 1 V -1 03/05/24, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53955
-
Andreas Nedbal uploaded patch set 2
V -103/05/24, 15:13 -
core-ci voted on patch set 2 V +1 03/05/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53956
-
Andreas Kienast commented on patch set 2 CR -1 03/05/24, 15:40
record-information.ts:53I think we can use the `lll()` helper instead. -
Andreas Nedbal uploaded patch set 3
CR -1V +103/05/24, 16:02 -
Andreas Nedbal commented on patch set 3 03/05/24, 16:04
backend.ts:80ReplyDonerecord-information.ts:53ReplyThis (sadly) has to be done because we are switching contexts with this component being used in a modal. lll() just accesses TYPO3.lang, which only contains the top window locales, not the module specific ones. -
core-ci voted on patch set 3 V +1 03/05/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53965
-
Andreas Kienast commented on patch set 3 03/05/24, 16:14
record-information.ts:53ReplyAcknowledged -
Andreas Nedbal rebased onto patch set 4
V +103/07/24, 11:31The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js -
Andreas Nedbal uploaded patch set 5 03/07/24, 11:33
-
Andreas Nedbal marked it ready for review 03/07/24, 11:33
-
core-ci voted on patch set 5 V +1 03/07/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54135
-
core-ci voted on patch set 4 V -1 03/07/24, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54134
-
Andreas Kienast voted on patch set 5 CR +1 V +1 03/07/24, 17:03
-
Benni Mack voted on patch set 5 CR +1 V +1 03/07/24, 17:20
-
Andreas Nedbal voted on patch set 5 CR +2 V +2 03/07/24, 17:54
-
Andreas Nedbal merged patch set 6 03/07/24, 17:54
backend.ts:80