Review main Merged

83218[TASK] Use native drag&drop API in page module

Andreas Nedbal CR +2 V +2 Hard +231 −182 updated 03/08/24, 13:14

Commit message

interactjs was introduced in page module drag&drop handling with #98471.
It turned out that the library is not necessarily required and is
therefore replaced with native drag&drop API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1423

  1. Andreas Nedbal uploaded patch set 1 03/05/24, 17:55

  2. core-ci voted on patch set 1 V +1 03/05/24, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53976

  3. Andreas Nedbal uploaded patch set 2 V +1 03/06/24, 17:42

  4. core-ci voted on patch set 2 V +1 03/06/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54063

  5. Andreas Nedbal uploaded patch set 3 V +1 03/06/24, 20:56

  6. core-ci voted on patch set 3 V -1 03/06/24, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54077

  7. Andreas Nedbal uploaded patch set 4 V -1 03/06/24, 21:08

  8. core-ci voted on patch set 4 V +1 03/06/24, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54078

  9. Andreas Kienast commented on patch set 4 V -1 03/07/24, 08:46

    When I have multiple elements in a colPos, dragging anything *but* the first one into their respective above dropzone despawns the element (it appears after a reload again).
  10. Andreas Nedbal uploaded patch set 5 V +1 03/07/24, 08:57

  11. Andreas Nedbal uploaded patch set 6 03/07/24, 08:57

  12. core-ci voted on patch set 5 V +1 03/07/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54114

  13. Andreas Nedbal commented on patch set 6 03/07/24, 09:03

    Reply

    Done
  14. core-ci voted on patch set 6 V -1 03/07/24, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54115

  15. Andreas Nedbal uploaded patch set 7 V -1 03/07/24, 09:07

  16. core-ci voted on patch set 7 V +1 03/07/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54117

  17. Andreas Nedbal uploaded patch set 8 V +1 03/07/24, 09:45

  18. core-ci voted on patch set 8 V +1 03/07/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54124

  19. Andreas Nedbal uploaded patch set 9 V +1 03/07/24, 17:39

  20. core-ci voted on patch set 9 V +1 03/07/24, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54160

  21. Andreas Kienast voted on patch set 9 CR +1 V +1 03/08/24, 12:57

  22. Benni Mack voted on patch set 9 CR +2 V +2 03/08/24, 13:14

  23. Benni Mack merged patch set 10 03/08/24, 13:14