Review main Merged

83220[BUGFIX] Allow single table view for page translations

Marvin Buchmann CR +2 V +2 Easy +15 −8 updated 01/22/25, 11:44

Commit message

Single table view for page translations is now available.
Listing page translations in the list module
no longer uses configuration of table pages
making it respect page TSconfig settings.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1824

  1. Marvin Buchmann uploaded patch set 1 03/05/24, 20:51

  2. core-ci voted on patch set 1 V +1 03/05/24, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53983

  3. Benni Mack updated the commit message in patch set 2 V +1 03/05/24, 21:37

  4. Benni Mack commented on patch set 2 03/05/24, 21:41

    sorry, but this does not work for completely. If i have 10 subpages, the pagination for "regular" subpages table does not work.
  5. Christian Kuhn commented on patch set 2 03/05/24, 21:42

    DatabaseRecordList.php:547

    nit-pick: init the two vars to null above the if and skip else.
  6. core-ci voted on patch set 2 V +1 03/05/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53985

  7. Marvin Buchmann commented on patch set 2 03/06/24, 08:44

    Reply

    This is because $GLOBALS['TCA']['pages']['interface']['maxDBListItems'] is set to a higher value and has higher priority. 'pages' appears to be the only table having it set by default. If this behaviour should be changed, the only option seems to be removing the fixed value from TCA, which would lead to using the TSconfig value, if set, and the default value (20, single table: 100) instead of the current TCA value (30, single table: 50) if not set.
  8. Marvin Buchmann uploaded patch set 3 V +1 04/15/24, 13:40

  9. core-ci voted on patch set 3 V +1 04/15/24, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55994

  10. Marvin Buchmann commented on patch set 3 04/15/24, 13:51

    Reply

    I just uploaded a new patch set removing the default TCA values. Therefore, the TSconfig value is now used, if set. If it is not set, the listed pages now use the same defaults as any other table (20, single table view: 100) instead of the previously defined ones (30, single table view: 50).

    DatabaseRecordList.php:547 Reply

    Done
  11. Marvin Buchmann rebased onto patch set 4 V +1 08/01/24, 18:37

  12. core-ci voted on patch set 4 V +1 08/01/24, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62607

  13. Georg Ringer commented on patch set 4 08/01/24, 18:50

    pages.php:63

    IMO just drop the interface array if empty
  14. Marvin Buchmann uploaded patch set 5 V +1 08/01/24, 18:54

  15. Marvin Buchmann commented on patch set 5 08/01/24, 18:55

    pages.php:63 Reply

    Acknowledged
  16. core-ci voted on patch set 5 V +1 08/01/24, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62610

  17. Benni Mack updated the commit message in patch set 6 V +1 10/18/24, 13:40

  18. Benni Mack rebased onto patch set 7 01/22/25, 08:28

  19. core-ci voted on patch set 7 V +1 01/22/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72827

  20. Benni Mack voted on patch set 7 CR +1 01/22/25, 08:46

  21. Benni Mack voted on patch set 7 V +1 01/22/25, 09:16

  22. Stefan Bürk voted on patch set 7 CR +1 V +1 01/22/25, 11:22

  23. Benni Mack voted on patch set 7 CR +2 V +2 01/22/25, 11:44

  24. Benni Mack merged patch set 8 01/22/25, 11:44