Review main Merged

83221[BUGFIX] Allow empty page id for pageId in log module

Georg Ringer CR +2 V +2 Easy +2 −2 updated 03/11/24, 09:58

Commit message

Allow empty strings as valid input for the page id in the log module.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 03/05/24, 22:08

  2. Georg Ringer commented on patch set 1 03/05/24, 22:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/05/24, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53988

  4. Andreas Kienast commented on patch set 1 03/06/24, 07:05

    Constraint.php:153

    Is it ensured that `$id` is always a string?
  5. Georg Ringer commented on patch set 1 03/06/24, 10:37

    Constraint.php:153 Reply

    IMO yes
  6. Christian Kuhn commented on patch set 1 03/07/24, 08:45

    Constraint.php:153 Reply

    i tried to debug in this area, but did not fully understand details of the property mapping stuff and stopped when it became more complicated. it looked to me as if null could be a possible value as well.
  7. Georg Ringer commented on patch set 1 03/07/24, 10:40

    Constraint.php:153 Reply

    so how to proceed now? IMO it works now same as before but the edge case with no id given works now. why so complicated?
  8. Christian Kuhn uploaded patch set 2 V +1 03/11/24, 09:18

  9. Christian Kuhn commented on patch set 2 03/11/24, 09:23

    Constraint.php:153 Reply

    What puzzled me with your solution, was, that by making it a string and casting in the model defeats the purpose of the property mapper, whos job is to feed models with properly mapped values. For pageId, the target type is clearly an int, with the only shenanigan that the interface allows sending an empty string. Changing the patch to force ?int is imho a more clean solution and then have a null fallback within the setter is imho more clean.
  10. core-ci voted on patch set 2 V +1 03/11/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54350

  11. Christian Kuhn voted on patch set 2 CR +1 V +1 03/11/24, 09:25

  12. Andreas Kienast commented on patch set 2 CR +1 V +1 03/11/24, 09:32

    Much cleaner solution <3
  13. Jasmina Ließmann voted on patch set 2 CR +1 V +1 03/11/24, 09:38

  14. Christian Kuhn voted on patch set 2 CR +2 V +2 03/11/24, 09:58

  15. Christian Kuhn merged patch set 3 03/11/24, 09:58