83224[TASK] Add meaningful title to File selector add file button
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1216
-
Willi Wehmeier uploaded patch set 1 03/06/24, 08:21
-
core-ci voted on patch set 1 V -1 03/06/24, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53999
-
Willi Wehmeier uploaded patch set 2
V -103/06/24, 08:56 -
core-ci voted on patch set 2 V +1 03/06/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54006
-
Christian Kuhn uploaded patch set 3
V +103/11/24, 12:06 -
Christian Kuhn voted on patch set 3 CR +1 V +1 03/11/24, 12:06
-
core-ci voted on patch set 3 V +1 03/11/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54359
-
Christian Kuhn commented on patch set 3 03/11/24, 12:30
waiting for a day to give ac-team a chance to look at the title/aria-label duplication topic. i tend to merge tomorrow if there is no additional feedback. -
Oli Bartsch uploaded patch set 4
CR +1V +103/12/24, 09:29 -
Oli Bartsch voted on patch set 4 CR +1 V +1 03/12/24, 09:29
-
core-ci voted on patch set 4 V +1 03/12/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54405
-
Michael Telgkamp commented on patch set 4 CR +1 V +1 03/13/24, 09:11
This is fine for now, as it is an improvement. The remaining Problem of the non accessible tooltip using the title attribute will be handled globally as part of https://forge.typo3.org/issues/89872 -
Christian Kuhn commented on patch set 4 03/13/24, 09:16
Thx Michael. I'll wait for further feedback until this evening. -
Benjamin Franzke commented on patch set 4 CR +1 V +1 03/13/24, 10:00
Tested with nvda and windows voice over in chrome and firefox. Title/label is only read once 👍 cc @benjamin.kott@outlook.com I think you had the case that bitv tests complained about aria-label + title being set, because they were read twice. To you remember which browser/voice-over that was? (I think that was NVDA, but that issues is supposed to be fixed https://github.com/nvaccess/nvda/issues/7841 – and worked for me with nvda as written above) -
Oli Bartsch voted on patch set 4 CR +2 V +2 03/13/24, 18:28
-
Oli Bartsch merged patch set 5 03/13/24, 18:33