Review main Merged

83228[BUGFIX] Avoid race condition in DI cache persistence

Benjamin Franzke CR +2 V +2 Easy +0 −7 updated 03/08/24, 21:12

Commit message

With #90418 the container cache has been excluded from the
regular cache-flush-pipeline.
Therefore flushing has been explicitly performed when writing a
new cache entry (with the intent to clean up old cache entries).

Issue is: Cleaning up the entire folder by deleting the folder means
a concurrent request – that is creating the same DI cache as well –
will fail to write the cache when the folder is (re)moved in that
moment.

It turns out this cache-flush is not needed at all, since the cache
identifier is stable for an TYPO3 instance, therefore a pre-flight
flush can be dropped.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Benjamin Franzke uploaded patch set 1 03/06/24, 09:12

  2. core-ci voted on patch set 1 V +1 03/06/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54008

  3. Benjamin Franzke uploaded patch set 2 V +1 03/06/24, 09:24

  4. Andreas Kienast voted on patch set 2 CR +1 03/06/24, 09:30

  5. core-ci voted on patch set 2 V +1 03/06/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54009

  6. Stefan Bürk voted on patch set 2 CR +1 03/06/24, 09:34

  7. Stefan Bürk voted on patch set 2 V +1 03/08/24, 19:53

  8. Benni Mack voted on patch set 2 CR +1 V +1 03/08/24, 20:09

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/08/24, 21:12

  10. Benjamin Franzke merged patch set 3 03/08/24, 21:12