Review main Merged

83231[DOCS] Switch Dashboard documentation to PHP-based rendering

Lina Wolf CR +2 V +2 Normal +47 −133 updated 03/06/24, 12:15

Commit message

* Introduce a guides.xml, the presence of this file
  triggers the new rendering.
* Replace usage of :php:class: textroles with :php:
  textroles. The former where used without having a target
* remove superfluous genindex, it is not supported anymore
* Remove old Settings.cfg, was only used for Sphinx

Attention: Backports need manual changes to the guides.xml.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 68

  1. Lina Wolf uploaded patch set 1 03/06/24, 11:24

  2. Lina Wolf updated the commit message in patch set 2 03/06/24, 11:24

  3. core-ci voted on patch set 1 V +1 03/06/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54023

  4. core-ci voted on patch set 2 V +1 03/06/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54024

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 03/06/24, 11:33

    👍
  6. Georg Ringer voted on patch set 2 CR +1 V +1 03/06/24, 12:09

  7. Lina Wolf voted on patch set 2 CR +2 V +2 03/06/24, 12:15

  8. Lina Wolf merged patch set 3 03/06/24, 12:15