Review main Merged

83260[TASK] Replace GeneralUtility::hmac usage in ext:frontend

Torben Hansen CR +2 V +2 Easy +13 −6 updated 03/08/24, 17:33

Commit message

With #102761, the new `HashService` has been introduced to ensure
that HMAC generation will always use an additional secret. As a
follow-up patch, `GeneralUtility::hmac` will be deprecated when all
usages in the core have been replaced with the new `HashService`.

With this change, usages of `GeneralUtility::hmac` in ext:frontend
are replaced by the new HashService.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 45

  1. Torben Hansen uploaded patch set 1 03/06/24, 15:51

  2. core-ci voted on patch set 1 V +1 03/06/24, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54048

  3. Benni Mack voted on patch set 1 CR +1 V +1 03/08/24, 17:09

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 03/08/24, 17:33

  5. Stefan Bürk merged patch set 2 03/08/24, 17:33