83264[DOCS] Streamline installation chapters of system extension manuals
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Garvin Hicking +1
-
Verified V +2 Done
- Lina Wolf +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 39
- typo3/sysext/adminpanel/Documentation/Installation/Index.rst5+2 −2
- typo3/sysext/dashboard/Documentation/Installation/Index.rst12+19 −17
- typo3/sysext/felogin/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/felogin/Documentation/Installation/Index.rstnew+57 −0
- typo3/sysext/felogin/Documentation/Index.rst+1 −0
- typo3/sysext/fluid_styled_content/Documentation/Images/ManualScreenshots/Installation/ActivateExtension.pngbinary
- typo3/sysext/fluid_styled_content/Documentation/Installation/Index.rst+34 −56
- typo3/sysext/form/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/form/Documentation/Installation/Index.rstnew+52 −0
- typo3/sysext/form/Documentation/Index.rst+1 −0
- typo3/sysext/impexp/Documentation/Images/ManualScreenshots/InstallActivate.pngnewbinary
- typo3/sysext/impexp/Documentation/Images/ManualScreenshots/InstallationNonComposer.pngdeletedbinary
- typo3/sysext/impexp/Documentation/Installation/Index.rst+34 −37
- typo3/sysext/indexed_search/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/indexed_search/Documentation/Installation/Index.rstnew+52 −0
- typo3/sysext/indexed_search/Documentation/Index.rst+1 −0
- typo3/sysext/linkvalidator/Documentation/Administration/Index.rstdeleted+0 −40
- typo3/sysext/linkvalidator/Documentation/Images/ActivateLinkValidator.pngbinary
- typo3/sysext/linkvalidator/Documentation/Installation/Index.rstnew+64 −0
- typo3/sysext/linkvalidator/Documentation/Index.rst+1 −1
Show 19 more files
- typo3/sysext/lowlevel/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/lowlevel/Documentation/Installation/Index.rst+40 −5
- typo3/sysext/reactions/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/reactions/Documentation/Installation/Index.rst+39 −4
- typo3/sysext/recycler/Documentation/Installation/Index.rst+1 −1
- typo3/sysext/redirects/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/redirects/Documentation/Installation/Index.rst+40 −4
- typo3/sysext/reports/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/reports/Documentation/Installation/Index.rst+35 −12
- typo3/sysext/rte_ckeditor/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/rte_ckeditor/Documentation/Installation/Index.rst+38 −11
- typo3/sysext/scheduler/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/scheduler/Documentation/Installation/Installing/Index.rst+53 −11
- typo3/sysext/seo/Documentation/Images/em.pngbinary
- typo3/sysext/seo/Documentation/Installation/Index.rst+28 −30
- typo3/sysext/sys_note/Documentation/Installation/Index.rst+1 −1
- typo3/sysext/workspaces/Documentation/Images/InstallActivate.pngnewbinary
- typo3/sysext/workspaces/Documentation/Installation/Index.rstnew+52 −0
- typo3/sysext/workspaces/Documentation/Index.rst+1 −0
Review log 1923
-
Chris Müller uploaded patch set 1 03/06/24, 16:26
-
Chris Müller updated the commit message in patch set 2 03/06/24, 16:27
-
core-ci voted on patch set 1 V +1 03/06/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54054
-
core-ci voted on patch set 2 V +1 03/06/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54055
-
Garvin Hicking commented on patch set 2 CR +1 V +1 03/06/24, 21:49
Great, cumbersome work - thanks! -
Lina Wolf commented on patch set 2 03/07/24, 06:02
Thanks for taking the trouble to streamline this. Just some small remarksIndex.rst:27Do we really want to copy all descriptions of the affected manuals here?Index.rst:10Is there a value in mentioning this?Index.rst:37should we mention the how to set the version? Cause if you have a TYPO3 v12.4 installation and 13.0 is already released you have to explicitly set the version -
Garvin Hicking commented on patch set 2 03/07/24, 08:39
Index.rst:37ReplyThe version constraints of cms-dashboard of the v13 release would contain a constraint to cms-core:13.0 - composer won't resolve that, so only a dashboard with cms-core:12.0 constraint would be added. IMO this streamlines the inclusion quite well, and we don't need to touch those documents in the future to adapt version strings here -
Lina Wolf commented on patch set 2 03/07/24, 08:41
Index.rst:37ReplyCan we maybe link somewhere where dealing with versions is explained? -
Chris Müller uploaded patch set 3
CR +1V +103/07/24, 11:12 -
core-ci voted on patch set 3 V +1 03/07/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54132
-
Chris Müller commented on patch set 3 03/07/24, 11:28
Index.rst:27ReplyIt is the full line outputted from "composer show", so it does not hurt to have it.Index.rst:10ReplyIt is already there in this manual, not only in the Installation part: https://docs.typo3.org/c/typo3/cms-dashboard/12.4/en-us/Configuration/Index.html When we remove this, this should be done in a separate patch (for all pages in all manuals).Index.rst:37ReplyI see no benefit: run "composer require" and the corresponding version is installed. That's it. No thinking about versions. -
Lina Wolf commented on patch set 3 03/07/24, 11:33
Index.rst:27ReplyI think that it will give us more places to edit when descriptions changeIndex.rst:10ReplyI thought we were streamlining all Installation chapters. The others don't have thisIndex.rst:37Replycomposer require try to install the newest version and then tells you that it is not compatible with your project -
Chris Müller commented on patch set 3 03/07/24, 11:43
Index.rst:10ReplyYup, but it would be then inconsistent with the other pages of that manual. And: This topic (target groups) should be discussed separately.Index.rst:37ReplyThat would only happen, when you want to require an outdated sysext, which is not compatible with your TYPO3 installation. Then you would get the same error, so no benefit. Like requiring typo3/cms-about:^9.5 in a 12.4 installation. -
Chris Müller uploaded patch set 4
V +103/07/24, 11:51 -
Chris Müller commented on patch set 4 03/07/24, 11:52
Index.rst:27ReplyDone -
Lina Wolf commented on patch set 4 03/07/24, 11:53
Index.rst:10ReplyAcknowledgedIndex.rst:37ReplyJust tried it out and it indeed seems to work by now -
Lina Wolf commented on patch set 4 03/07/24, 11:55
Index.rst:27ReplyDone -
core-ci voted on patch set 4 V +1 03/07/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54137
-
Lina Wolf voted on patch set 4 CR +1 V +1 03/07/24, 11:57
-
Lina Wolf commented on patch set 4 03/07/24, 11:57
Good work, thank you -
Garvin Hicking voted on patch set 4 CR +1 V +1 03/07/24, 12:10
-
Lina Wolf voted on patch set 4 CR +2 V +2 03/07/24, 12:17
-
Lina Wolf merged patch set 5 03/07/24, 12:17