Review main Merged

83269[TASK] Migrate "move page" wizard to a modal

Andreas Kienast CR +2 V +2 Hard +561 −122 updated 03/08/24, 19:40

Commit message

The "Move page" wizard is still based on the dusted `PagePositionMap`.
In order to modernize the clunky UI, the wizard is migrated to a modal
window that offers a drastically slimmed down interface, offering a page
tree to make the selection of the target page easier.

It is always possible to paste the to-be-moved page above and below a
target page, or inside a page if there are no children, yet.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1522

  1. Andreas Kienast uploaded patch set 1 03/06/24, 19:07

  2. core-ci voted on patch set 1 V -1 03/06/24, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54068

  3. Andreas Kienast uploaded patch set 2 V -1 03/07/24, 11:37

  4. core-ci voted on patch set 2 V -1 03/07/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54136

  5. Andreas Kienast uploaded patch set 3 V -1 03/07/24, 15:18

  6. core-ci voted on patch set 3 V +1 03/07/24, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54146

  7. Andreas Kienast uploaded patch set 4 V +1 03/07/24, 16:33

  8. core-ci voted on patch set 4 V +1 03/07/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54151

  9. Andreas Kienast uploaded patch set 5 V +1 03/08/24, 13:12

  10. core-ci voted on patch set 5 V +1 03/08/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54262

  11. Benni Mack uploaded patch set 6 V +1 03/08/24, 13:55

  12. core-ci voted on patch set 6 V +1 03/08/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54263

  13. Benni Mack voted on patch set 6 CR +1 V +1 03/08/24, 14:33

  14. Stefan Bürk commented on patch set 6 CR -1 03/08/24, 17:50

    Seems that the labels for two action available in the burger menu (page tree) in the modal are missing ... (will add a screenshot to the issue)
  15. Christian Kuhn commented on patch set 6 CR -1 03/08/24, 18:01

    MovePageController.php:53

    it should be quite easy to make the controller readonly by avoiding the properties and handing them over to methods.
  16. Benni Mack uploaded patch set 7 CR +1 V +1 03/08/24, 18:17

  17. Benni Mack commented on patch set 6 CR +1 V +1 03/08/24, 18:17

    Reply

    Done

    MovePageController.php:53 Reply

    Done
  18. Benni Mack voted on patch set 7 CR +1 V +1 03/08/24, 18:17

  19. core-ci voted on patch set 7 V +1 03/08/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54295

  20. Christian Kuhn voted on patch set 7 CR +1 V +1 03/08/24, 18:33

  21. Benni Mack voted on patch set 7 CR +2 V +2 03/08/24, 19:40

  22. Benni Mack merged patch set 8 03/08/24, 19:40