83269[TASK] Migrate "move page" wizard to a modal
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/Sass/component/_tree.scss+1 −0
- Build/Sources/Sass/typo3/_element_page_position.scssnew+63 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/tree/page-browser.ts+2 −1
- Build/Sources/TypeScript/backend/wizard/move-page.tsnew+74 −0
- Build/Sources/TypeScript/backend/modal.ts+3 −1
- Build/Sources/TypeScript/backend/move-record-wizard-button.tsnew+89 −0
- typo3/sysext/backend/Classes/Controller/Page/MovePageController.php2+149 −96
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −0
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+3 −2
- typo3/sysext/backend/Resources/Private/Language/Wizards/move_page.xlfnew+47 −0
- typo3/sysext/backend/Resources/Private/Layouts/Page/MovePageLayout.htmlnew+36 −0
- typo3/sysext/backend/Resources/Private/Templates/Page/MovePage.html+54 −19
- typo3/sysext/backend/Resources/Public/Css/backend.css+10 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/move-page.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/move-record-wizard-button.jsnew+13 −0
Review log 1522
-
Andreas Kienast uploaded patch set 1 03/06/24, 19:07
-
core-ci voted on patch set 1 V -1 03/06/24, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54068
-
Andreas Kienast uploaded patch set 2
V -103/07/24, 11:37 -
core-ci voted on patch set 2 V -1 03/07/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54136
-
Andreas Kienast uploaded patch set 3
V -103/07/24, 15:18 -
core-ci voted on patch set 3 V +1 03/07/24, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54146
-
Andreas Kienast uploaded patch set 4
V +103/07/24, 16:33 -
core-ci voted on patch set 4 V +1 03/07/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54151
-
Andreas Kienast uploaded patch set 5
V +103/08/24, 13:12 -
core-ci voted on patch set 5 V +1 03/08/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54262
-
Benni Mack uploaded patch set 6
V +103/08/24, 13:55 -
core-ci voted on patch set 6 V +1 03/08/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54263
-
Benni Mack voted on patch set 6 CR +1 V +1 03/08/24, 14:33
-
Stefan Bürk commented on patch set 6 CR -1 03/08/24, 17:50
Seems that the labels for two action available in the burger menu (page tree) in the modal are missing ... (will add a screenshot to the issue) -
Christian Kuhn commented on patch set 6 CR -1 03/08/24, 18:01
MovePageController.php:53it should be quite easy to make the controller readonly by avoiding the properties and handing them over to methods. -
Benni Mack uploaded patch set 7
CR +1V +103/08/24, 18:17 -
Benni Mack commented on patch set 6 CR +1 V +1 03/08/24, 18:17
Reply
DoneMovePageController.php:53ReplyDone -
Benni Mack voted on patch set 7 CR +1 V +1 03/08/24, 18:17
-
core-ci voted on patch set 7 V +1 03/08/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54295
-
Christian Kuhn voted on patch set 7 CR +1 V +1 03/08/24, 18:33
-
Benni Mack voted on patch set 7 CR +2 V +2 03/08/24, 19:40
-
Benni Mack merged patch set 8 03/08/24, 19:40