Review main Merged

83270[TASK] Use composed `URL` in `@typo3/backend/tree/page-browser`

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 03/07/24, 17:25

Commit message

The module `@typo3/backend/tree/page-browser` used to modify a string
representing an URL by appending arguments to a query string. The code
is now modified to use a proper `URL` object, which is considered more
safe for such tasks.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 03/06/24, 19:15

  2. Andreas Nedbal voted on patch set 1 CR +1 V +1 03/06/24, 19:19

  3. core-ci voted on patch set 1 V +1 03/06/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54070

  4. Benni Mack voted on patch set 1 CR +1 V +1 03/07/24, 12:25

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 03/07/24, 17:19

  6. Andreas Kienast merged patch set 2 03/07/24, 17:25