Review main Merged

83296[BUGFIX] Prepare `allowed` and `disallowed` in more deeply nested TCA

Andreas Kienast CR +2 V +2 Hard +421 −20 updated 04/04/24, 15:07

Commit message

TCA for usage of `sys_file` may configure their allowed extensions by an
array (e.g. EXT:bootstrap_package, "Media" content element) which failed
as the Element Browser took only strings into account.

The class `TcaPreparation` now takes `columnsOverrides` and their
respective `overrideChildTca` configuration into account.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2031

Show 46 earlier messages
  1. Andreas Kienast uploaded patch set 1 03/07/24, 09:11

  2. core-ci voted on patch set 1 V +1 03/07/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54118

  3. Oli Bartsch commented on patch set 1 CR -1 03/07/24, 10:45

    TcaPreparation::prepareFileExtensions() should handle the transformation as it also respects the special "common-*-types" syntax. The reason, why this does not work here is that the config in question is done in "columnsOverrides" . Therefore we should adjust TcaPreparation to also handle the transformation in "columnsOverrides" and maybe also in "overrideChildTca".
  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 03/07/24, 19:08

  5. Andreas Kienast uploaded patch set 3 03/07/24, 19:09

  6. core-ci voted on patch set 2 V -1 03/07/24, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54183

  1. core-ci voted on patch set 3 V -1 03/07/24, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54184

  2. Andreas Kienast uploaded patch set 4 V -1 03/08/24, 07:52

  3. core-ci voted on patch set 4 V +1 03/08/24, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54208

  4. Andreas Kienast commented on patch set 4 03/08/24, 08:14

    Reply

    Done
  5. Anja Leichsenring updated the commit message in patch set 5 V +1 03/08/24, 08:22

  6. core-ci voted on patch set 5 V +1 03/08/24, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54209

  7. Andreas Kienast commented on patch set 5 03/08/24, 08:33

    Thanks, @aleichsenring@ab-softlab.de 😄
  8. Andreas Kienast uploaded patch set 6 V +1 03/08/24, 13:09

  9. core-ci voted on patch set 6 V -1 03/08/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54260

  10. Andreas Kienast uploaded patch set 7 V -1 03/08/24, 14:32

  11. core-ci voted on patch set 7 V +1 03/08/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54265

  12. Garvin Hicking commented on patch set 7 CR +1 V +1 03/14/24, 08:23

    Fixes the reported issue to me, lgtm :-)
  13. Andreas Kienast voted on patch set 7 CR -1 03/15/24, 10:18

  14. Andreas Kienast uploaded patch set 8 CR +1 V +1 03/15/24, 10:29

  15. core-ci voted on patch set 8 V -1 03/15/24, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54576

  16. Andreas Kienast uploaded patch set 9 V -1 03/15/24, 10:37

  17. core-ci voted on patch set 9 V +1 03/15/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54577

  18. Andreas Kienast uploaded patch set 10 V +1 03/15/24, 10:43

  19. core-ci voted on patch set 10 V +1 03/15/24, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54578

  20. Nikita Hovratov uploaded patch set 11 V +1 03/23/24, 18:55

  21. core-ci voted on patch set 11 V +1 03/23/24, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54892

  22. Nikita Hovratov commented on patch set 11 CR +1 V +1 03/23/24, 19:01

    Looks super complicated and hard to read ngl, but does the job well and has good test coverage, so ok. Just moved the test dataProvider above the test method, as this is the norm (according to lolli at least). Btw this is nice as I can remove a workaround in Content Blocks and probably in Mask as well thanks to this patch.
  23. Garvin Hicking voted on patch set 11 CR +1 V +1 03/23/24, 20:13

  24. Andreas Kienast voted on patch set 11 CR +2 V +2 04/04/24, 15:00

  25. Andreas Kienast merged patch set 12 04/04/24, 15:07