83299[TASK] Avoid duplicate image crop (crop-crop-scale to crop-scale)
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php2+13 −39
- typo3/sysext/core/Classes/Imaging/ImageDimension.php2+5 −112
- typo3/sysext/core/Classes/Imaging/ImageProcessingInstructions.php6+264 −125
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+1 −18
- typo3/sysext/core/Tests/Unit/Imaging/ImageDimensionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessingInstructionsTest.php+69 −87
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+8 −10
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+10 −12
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/seo/Tests/Functional/MetaTag/MetaTagGeneratorTest.php+2 −1
Review log 2944
Show 1019 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/07/24, 09:19
-
core-ci voted on patch set 1 V -1 03/07/24, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54122
-
Benjamin Franzke uploaded patch set 2
V -103/07/24, 10:38 -
core-ci voted on patch set 2 V -1 03/07/24, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54128
-
Benjamin Franzke uploaded patch set 3
V -103/07/24, 11:04 -
core-ci voted on patch set 3 V -1 03/07/24, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54130
-
Benjamin Franzke uploaded patch set 4
V -103/07/24, 21:00 -
core-ci voted on patch set 4 V -1 03/07/24, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54192
-
Benjamin Franzke uploaded patch set 5
V -103/07/24, 21:59 -
core-ci voted on patch set 5 V -1 03/07/24, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54198
-
Benjamin Franzke uploaded patch set 6
V -103/07/24, 22:17 -
core-ci voted on patch set 6 V +1 03/07/24, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54199
-
Benjamin Franzke uploaded patch set 7
V +103/07/24, 22:29 -
core-ci voted on patch set 7 V -1 03/07/24, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54200
-
Benjamin Franzke uploaded patch set 8
V -103/07/24, 22:39 -
core-ci voted on patch set 8 V +1 03/07/24, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54201
-
Benjamin Franzke uploaded patch set 9
V +103/08/24, 09:05 -
core-ci voted on patch set 9 V +1 03/08/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54212
-
Benjamin Franzke uploaded patch set 10
V +103/08/24, 18:17
-
core-ci voted on patch set 10 V +1 03/08/24, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54296
-
Benjamin Franzke uploaded patch set 11
V +103/08/24, 18:55 -
core-ci voted on patch set 11 V +1 03/08/24, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54303
-
Benni Mack commented on patch set 11 03/08/24, 19:24
-
Benjamin Franzke uploaded patch set 12
V +103/08/24, 19:30 -
Benjamin Franzke commented on patch set 12 03/08/24, 19:30
GraphicalFunctions.php:464ReplyDone -
core-ci voted on patch set 12 V +1 03/08/24, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54306
-
Benjamin Franzke rebased onto patch set 13
V +103/08/24, 21:06 -
core-ci voted on patch set 13 V +1 03/08/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54309
-
Benni Mack commented on patch set 13 03/08/24, 21:52
ImageDimension.php:91so good to get rid of this code!ImageProcessingInstructions.php:144should always throw an exception, I think this is OK.ImageProcessingInstructions.php:169we can move the (int)casting now to line 160, I guess.ImageProcessingInstructions.php:211better exception handling (I think we need a custom / new exception here) -
Benjamin Franzke uploaded patch set 14
V +103/11/24, 07:17 -
Benjamin Franzke commented on patch set 14 03/11/24, 07:17
ImageDimension.php:91ReplyAcknowledgedImageProcessingInstructions.php:144ReplyDoneImageProcessingInstructions.php:169ReplyNo, because `$cropOffsetHorizontal = (int)substr((string)strstr((string)$width, 'c'), 1);` still needs the string value to be able to chop of the `'c'` suffix.ImageProcessingInstructions.php:211Replyack, totally forgot about that one. I think this case would actually be a bug in our code and therefore marked it as `LogicException`. -
core-ci voted on patch set 14 V +1 03/11/24, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54347
-
Benni Mack voted on patch set 14 CR +1 V +1 03/11/24, 07:43
-
Andreas Kienast voted on patch set 14 CR +1 03/11/24, 08:19
-
Oliver Hader commented on patch set 14 CR -1 03/11/24, 08:51
Will test this soon... -
Garvin Hicking commented on patch set 14 CR +1 V +1 03/11/24, 09:15
Huge rework, I probably can't grasp all of it, but the tests I performed with various assets and crops all worked. Tests feel confident too. :D Thanks to all involved for putting so much work effort into this, much appreciated! -
Oliver Hader uploaded patch set 15
CR +1V +103/11/24, 15:04 -
Oliver Hader commented on patch set 15 CR +1 V +1 03/11/24, 15:07
Upscaling is different, but looks visually correct now. I've extracted test some test changes to https://review.typo3.org/c/Packages/TYPO3.CMS/+/83405 to reflect the `inline max` changes... -
core-ci voted on patch set 15 V +1 03/11/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54370
-
Benni Mack voted on patch set 15 CR +1 V +1 03/11/24, 15:20
-
Garvin Hicking voted on patch set 15 CR +1 V +1 03/11/24, 15:52
-
Benni Mack commented on patch set 15 CR +2 V +2 03/11/24, 15:53
Reply
Done -
Benni Mack merged patch set 16 03/11/24, 15:53
-
Benjamin Franzke commented on patch set 15 CR +2 V +2 03/11/24, 15:55
Reply
Thanks for the adaptions.
GraphicalFunctions.php:464