Review main Abandoned

83301[WIP][BUGFIX] Show translate button in page module only when necessary

Marvin Buchmann CR 0 V 0 Normal +58 −23 updated 11/11/26, 10:59

Commit message

This aims to prevent creating
invalid translations in the page module
by checking the source language instead
of the default language in the display condition
for the button since the translation creation
checks for the source language as well.
It is still WIP because of missing tests.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Marvin Buchmann uploaded patch set 1 03/07/24, 11:07

  2. core-ci voted on patch set 1 V +1 03/07/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54131

  3. Marvin Buchmann uploaded patch set 2 V +1 03/07/24, 17:37

  4. core-ci voted on patch set 2 V +1 03/07/24, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54159

  5. Benni Mack marked it work in progress 04/11/25, 21:16

  6. Benni Mack abandoned the change 11/11/26, 10:59

    this has been solved in the meantime with issue #92937