Review main Merged

83303[TASK] Remove internal declaration for hashService property in actionController

Torben Hansen CR +2 V +2 Easy +1 −5 updated 03/07/24, 15:33

Commit message

With #92996 the property `hashService` in extbase `actionController`
has been marked as internal. This change was most likely made,
because the extbase `hashService` class was declared as internal.

The extbase `HashService` has been deprecated with #102763 and
extbase `actionController` now uses the new `HashService` introduced
with #102761, which is public API. Therefore, the internal declaration
for the property `hashService` in `actionController` can be removed
again, so extension authors can use the `hashService` for e.g. HMAC
validation.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 4

Files 1