Review main Merged

83305[TASK] Allow string as typoScript PAGE typeNum

Christian Kuhn CR +2 V +2 Normal +138 −5 updated 03/07/24, 17:18

Commit message

It was never clear if and why typeNum needs to be
a number. With recent TSFE refactorings, it becomes
more clear we can easily allow strings.
The patch adapts this as covers various scenarios
around PAGE determination with functional tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 69

  1. Christian Kuhn uploaded patch set 1 03/07/24, 14:58

  2. core-ci voted on patch set 1 V +1 03/07/24, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54144

  3. Christian Kuhn uploaded patch set 2 V +1 03/07/24, 16:06

  4. core-ci voted on patch set 2 V +1 03/07/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54149

  5. Benni Mack uploaded patch set 3 V +1 03/07/24, 16:19

  6. Benni Mack voted on patch set 3 CR +1 V +1 03/07/24, 16:20

  7. core-ci voted on patch set 3 V +1 03/07/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54150

  8. Stefan Bürk voted on patch set 3 CR +2 V +2 03/07/24, 17:17

  9. Stefan Bürk merged patch set 4 03/07/24, 17:18