Review main Merged

83308[TASK] Remove jQuery from @typo3/workspaces/backend

Andreas Nedbal CR +2 V +2 Hard +195 −187 updated 03/08/24, 14:47

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Andreas Nedbal uploaded patch set 1 03/07/24, 16:40

  2. core-ci voted on patch set 1 V +1 03/07/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54152

  3. Andreas Nedbal rebased onto patch set 2 V +1 03/07/24, 17:55

  4. core-ci voted on patch set 2 V +1 03/07/24, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54164

  5. Andreas Kienast commented on patch set 2 CR -1 03/08/24, 08:48

    on it

    backend.ts:216

    `this.viewChanges` and `this.openPreview` are still arrow-based. This can be resolved now.
  6. Andreas Kienast uploaded patch set 3 CR -1 V +1 03/08/24, 09:07

  7. Andreas Kienast commented on patch set 3 CR +1 V +1 03/08/24, 09:08

    backend.ts:216 Reply

    Done
  8. core-ci voted on patch set 3 V +1 03/08/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54213

  9. Christian Kuhn commented on patch set 3 V -1 03/08/24, 10:35

    minor detail. andy will fix.
  10. Andreas Kienast voted on patch set 3 V 0 CR -1 03/08/24, 10:36

  11. Andreas Kienast uploaded patch set 4 CR -1 V +1 03/08/24, 10:41

  12. Andreas Kienast commented on patch set 4 03/08/24, 10:42

    Reply

    Done
  13. core-ci voted on patch set 4 V +1 03/08/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54231

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 03/08/24, 12:55

  15. Benni Mack voted on patch set 4 CR +2 V +2 03/08/24, 14:47

  16. Benni Mack merged patch set 5 03/08/24, 14:47