Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Orphaned

83317[BUGFIX] Make full area of CEs preview-text clickable

Ayke Halder CR 0 V -1 Easy +6 −0 updated 04/22/26, 13:06

Commit message

In the backend each CE has some preview-text. The area of the
preview-text is fully clickable now.

Before some space between multiple text lines was not clickable by
editors.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/17/83317/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/17/83317/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 2

Review log 711

  1. Ayke Halder uploaded patch set 1 03/07/24, 18:31

  2. Stefan Bürk updated the commit message in patch set 2 03/07/24, 18:39

  3. core-ci voted on patch set 2 V +1 03/07/24, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54179

  4. core-ci voted on patch set 1 V +1 03/07/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54178

  5. Nikita Hovratov voted on patch set 2 V +1 03/08/24, 21:05

  6. Riccardo De Contardi commented on patch set 2 03/13/24, 09:52

    Please see my comment

    _page.scss:308

    Maybe it's just my opinion; isn't it a bit an overkill? Shouldn't a display:inline-block be sufficient?
  7. Ayke Halder commented on patch set 2 03/13/24, 10:12

    _page.scss:308 Reply

    There are multiple a-tags involved. When we use display:inline-block here it totally breaks the positioning of elements. ``` <div class="element-preview-content"> <a href="#">Test text<br>Test</a> <a href="#"><div class="preview-thumbnails" style="--preview-thumbnails-size: 64px"><div class="preview-thumbnails-element"><div class="preview-thumbnails-element-image"><img src="..."></div></div></div></a> </div> ```
  8. Benni Mack updated the commit message in patch set 3 V +1 10/18/24, 13:24

  9. core-ci voted on patch set 3 V -1 10/18/24, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67961

  10. Benni Mack updated the commit message in patch set 4 V -1 04/22/26, 06:56

  11. core-ci voted on patch set 4 V -1 04/22/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100841