Review main Merged

83318[FEATURE] Add Gaelic (gd) as supported language

Frank Nägler CR +2 V +2 Easy +35 −0 updated 03/12/24, 12:14

Commit message

This change adds support for Scottish Gaelic to be selected
as TYPO3 Language and to connect to TYPO3 Localizations
(XLF files, Site Configuration) by default.

Scottish Gaelic language is spoken in Scotland.

[1] https://en.wikipedia.org/wiki/Scottish_Gaelic
[2] https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Frank Nägler +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1723

  1. Frank Nägler uploaded patch set 1 03/07/24, 18:53

  2. Chris Müller commented on patch set 1 03/07/24, 19:01

    The typo3/sysext/setup/Resources/Private/Language/locallang.xlf should be adjusted, and maybe a rst file. See here for a blueprint: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74119
  3. core-ci voted on patch set 1 V +1 03/07/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54182

  4. Frank Nägler uploaded patch set 2 V +1 03/07/24, 19:10

  5. Frank Nägler uploaded patch set 3 03/07/24, 19:14

  6. Frank Nägler uploaded patch set 4 03/07/24, 19:15

  7. core-ci voted on patch set 2 V +1 03/07/24, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54185

  8. core-ci voted on patch set 3 V +1 03/07/24, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54186

  9. core-ci voted on patch set 4 V +1 03/07/24, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54187

  10. Marvin Buchmann commented on patch set 4 CR -1 03/07/24, 20:50

    The changelog rst refers to Gaelic in Scotland. According to ISO standard "ga" is the language code for Irish Gaelic. https://www.loc.gov/standards/iso639-2/php/code_list.php or https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes If Scottish Gaelic is the targeted language, the code would be "gd". Otherwise the changelog should refer to Irish or Irish Gaelic.

    Feature-103255-NativeSupportForLanguageGaelicAdded.rst:17

    is accessing -> accesses
  11. Marvin Buchmann commented on patch set 5 CR -1 V +1 03/07/24, 21:01

    Published edit on patch set 4.
  12. Marvin Buchmann commented on patch set 5 CR -1 03/07/24, 21:05

    Feature-103255-NativeSupportForLanguageGaelicAdded.rst:17 Reply

    Done
  13. core-ci voted on patch set 5 V +1 03/07/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54193

  14. Marvin Buchmann commented on patch set 5 03/07/24, 21:13

    Reply

    Resolved this comment accidentally. Irish (Gaelic) is the language that is supposed to be added, so the language code is correct.
  15. Christian Kuhn uploaded patch set 6 CR -1 V +1 03/11/24, 11:30

  16. Christian Kuhn commented on patch set 5 03/11/24, 11:30

    Reply

    using 'gd' and 'scottish gaelic' now.
  17. core-ci voted on patch set 6 V +1 03/11/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54357

  18. Christian Kuhn commented on patch set 6 CR +1 V +1 03/11/24, 11:39

    i'd be fine with this. a confirmation from frank 'gd' and 'scottish gaelic' was the intention of the patch would be good, though.
  19. Frank Nägler commented on patch set 6 CR +1 V +1 03/11/24, 11:53

    Fine with me, let's do a third patch for "ga" and merge this now.
  20. Stefan Bürk voted on patch set 6 CR +2 V +2 03/11/24, 11:55

  21. Stefan Bürk merged patch set 7 03/11/24, 11:55

  22. Stephan Großberndt commented on patch set 7 03/11/24, 12:39

    Reply

    > The typo3/sysext/setup/Resources/Private/Language/locallang.xlf should be adjusted, and maybe a rst file. > > See here for a blueprint: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74119 This comment from Chris was ignored - /typo3/sysext/setup/Resources/Private/Language/locallang.xlf is missing a lang_gd key now.
  23. Stephan Großberndt commented on patch set 7 03/12/24, 12:14

    Reply

    It no longer is necessary to add languages to that file @typo3@krue.ml as the translations were removed from it in https://review.typo3.org/c/Packages/TYPO3.CMS/+/77503