83318[FEATURE] Add Gaelic (gd) as supported language
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Frank Nägler +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Frank Nägler +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1723
-
Frank Nägler uploaded patch set 1 03/07/24, 18:53
-
Chris Müller commented on patch set 1 03/07/24, 19:01
The typo3/sysext/setup/Resources/Private/Language/locallang.xlf should be adjusted, and maybe a rst file. See here for a blueprint: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74119 -
core-ci voted on patch set 1 V +1 03/07/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54182
-
Frank Nägler uploaded patch set 2
V +103/07/24, 19:10 -
Frank Nägler uploaded patch set 3 03/07/24, 19:14
-
Frank Nägler uploaded patch set 4 03/07/24, 19:15
-
core-ci voted on patch set 2 V +1 03/07/24, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54185
-
core-ci voted on patch set 3 V +1 03/07/24, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54186
-
core-ci voted on patch set 4 V +1 03/07/24, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54187
-
Marvin Buchmann commented on patch set 4 CR -1 03/07/24, 20:50
The changelog rst refers to Gaelic in Scotland. According to ISO standard "ga" is the language code for Irish Gaelic. https://www.loc.gov/standards/iso639-2/php/code_list.php or https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes If Scottish Gaelic is the targeted language, the code would be "gd". Otherwise the changelog should refer to Irish or Irish Gaelic.Feature-103255-NativeSupportForLanguageGaelicAdded.rst:17is accessing -> accesses -
Marvin Buchmann commented on patch set 5
CR -1V +103/07/24, 21:01Published edit on patch set 4. -
Marvin Buchmann commented on patch set 5 CR -1 03/07/24, 21:05
Feature-103255-NativeSupportForLanguageGaelicAdded.rst:17ReplyDone -
core-ci voted on patch set 5 V +1 03/07/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54193
-
Marvin Buchmann commented on patch set 5 03/07/24, 21:13
Reply
Resolved this comment accidentally. Irish (Gaelic) is the language that is supposed to be added, so the language code is correct. -
Christian Kuhn uploaded patch set 6
CR -1V +103/11/24, 11:30 -
Christian Kuhn commented on patch set 5 03/11/24, 11:30
Reply
using 'gd' and 'scottish gaelic' now. -
core-ci voted on patch set 6 V +1 03/11/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54357
-
Christian Kuhn commented on patch set 6 CR +1 V +1 03/11/24, 11:39
i'd be fine with this. a confirmation from frank 'gd' and 'scottish gaelic' was the intention of the patch would be good, though. -
Frank Nägler commented on patch set 6 CR +1 V +1 03/11/24, 11:53
Fine with me, let's do a third patch for "ga" and merge this now. -
Stefan Bürk voted on patch set 6 CR +2 V +2 03/11/24, 11:55
-
Stefan Bürk merged patch set 7 03/11/24, 11:55
-
Stephan Großberndt commented on patch set 7 03/11/24, 12:39
Reply
> The typo3/sysext/setup/Resources/Private/Language/locallang.xlf should be adjusted, and maybe a rst file. > > See here for a blueprint: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74119 This comment from Chris was ignored - /typo3/sysext/setup/Resources/Private/Language/locallang.xlf is missing a lang_gd key now. -
Stephan Großberndt commented on patch set 7 03/12/24, 12:14
Reply
It no longer is necessary to add languages to that file @typo3@krue.ml as the translations were removed from it in https://review.typo3.org/c/Packages/TYPO3.CMS/+/77503