Review main Merged

83320[TASK] Deprecate ExtensionManagementUtility::addPItoST43()

Frank Nägler CR +2 V +2 Normal +68 −0 updated 09/12/24, 09:03

Commit message

The method \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPItoST43()
has been marked as deprecated and will be removed with TYPO3 v14.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3441

Show 1216 earlier messages
  1. Frank Nägler uploaded patch set 1 03/07/24, 20:48

  2. core-ci voted on patch set 1 V +1 03/07/24, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54190

  3. Georg Ringer voted on patch set 1 CR +1 V +1 03/08/24, 06:01

  4. Andreas Kienast commented on patch set 1 CR -1 03/08/24, 08:23

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36

    A cross-reference to another doc might help here.

    MethodCallStaticMatcher.php:165

    Only the argument `$key` is mandatory.

    MethodCallStaticMatcher.php:166

    The method accepts has a total of 5 arguments.
  5. Christian Kuhn commented on patch set 1 03/08/24, 10:38

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36 Reply

    yeah. this needs more information. a cross-reference is minumum, an example for "90% of cases" would be better.
  6. Frank Nägler uploaded patch set 2 CR +1 V +1 09/10/24, 17:24

  7. core-ci voted on patch set 2 V +1 09/10/24, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65298

  8. Torben Hansen commented on patch set 2 09/10/24, 17:49

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:37

    I think it is better to use a cross reference here instead of a hard link (which may change). Possible cross reference (untested - needs to be verified by documentation team): ``` :ref:`Plugin Registration API <t3coreapi:extbase_registration_of_frontend_plugins>` ```
  9. Frank Nägler commented on patch set 2 09/10/24, 17:52

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:37 Reply

    never saw this before, but I will check that, thx.

    MethodCallStaticMatcher.php:165 Reply

    Acknowledged

    MethodCallStaticMatcher.php:166 Reply

    Acknowledged
  10. Frank Nägler uploaded patch set 3 V +1 09/10/24, 17:55

  11. Frank Nägler uploaded patch set 4 09/10/24, 17:56

  12. Frank Nägler commented on patch set 4 09/10/24, 17:59

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:37 Reply

    Acknowledged
  13. Frank Nägler commented on patch set 4 09/10/24, 17:59

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36 Reply

    Acknowledged
  14. core-ci voted on patch set 3 V +1 09/10/24, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65305

  15. core-ci voted on patch set 4 V +1 09/10/24, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65308

  16. Benni Mack voted on patch set 4 CR +1 V +1 09/10/24, 18:10

  1. Garvin Hicking commented on patch set 4 09/10/24, 18:17

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36

    Could we maybe give an example here, to allow easier migration with an example before/after?
  2. Torben Hansen voted on patch set 4 CR +1 V +1 09/11/24, 06:28

  3. Frank Nägler commented on patch set 4 09/11/24, 07:25

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36 Reply

    I don't think so. We have a reference to documentation, and we know that the old function is used very rarely. I would copy example codes from the documentation.
  4. Lina Wolf commented on patch set 4 09/11/24, 09:19

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36 Reply

    EMU::addPItoST43() is however used in non-Extbase context, so linking the Extbase docs here is misleading.
  5. Simon Schaufelberger commented on patch set 4 CR -1 09/11/24, 19:01

    ExtensionManagementUtility.php:922

    this is not true. it should be at least 13.3
  6. Simon Schaufelberger commented on patch set 4 09/11/24, 19:02

    ExtensionManagementUtility.php:927

    same here
  7. Frank Nägler commented on patch set 5 CR +1 V +1 09/11/24, 19:45

    Published edit on patch set 4.
  8. Frank Nägler commented on patch set 5 09/11/24, 19:47

    ExtensionManagementUtility.php:922 Reply

    Done

    ExtensionManagementUtility.php:927 Reply

    Done
  9. core-ci voted on patch set 5 V +1 09/11/24, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65485

  10. Torben Hansen voted on patch set 5 CR +1 V +1 09/12/24, 06:15

  11. Benni Mack commented on patch set 5 09/12/24, 07:36

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36 Reply

    from reading the code multiple times: I think "addPItoST43" does not work if you ever use namespaced PHP classes such "Benni\MyExtension\Controller\MyController" It only ! works if you have PHP code that is called "class tx_myext_pi1" without a namespace - which also has a method called "main". This is because "addPItoST43" actually creates the TypoScript to a UserFunc with "plugin.tx_myext_pi1 = USER plugin.tx_myext_pi1.userFunc = tx_myext_pi1->main" I've searched through TER and only found places where people used the API method but then actually changed the TypoScript manually 😊 A prominent example: https://github.com/tpwd/ke_search/blob/master/ext_localconf.php#L17-L22
  12. Andreas Kienast voted on patch set 5 CR +1 V +1 09/12/24, 07:50

  13. Frank Nägler uploaded patch set 6 CR +1 V +1 09/12/24, 08:14

  14. Frank Nägler commented on patch set 5 09/12/24, 08:14

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36 Reply

    Acknowledged
  15. Andreas Kienast voted on patch set 6 CR +1 V +1 09/12/24, 08:14

  16. Oli Bartsch voted on patch set 6 CR +1 V +1 09/12/24, 08:15

  17. Garvin Hicking commented on patch set 6 CR +1 V +1 09/12/24, 08:21

    Thank you ☺️
  18. Garvin Hicking commented on patch set 6 09/12/24, 08:23

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:41

    typo missing "x", but we can "fix it in post".
  19. core-ci voted on patch set 6 V +1 09/12/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65537

  20. Frank Nägler commented on patch set 6 09/12/24, 08:28

    Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:41 Reply

    Acknowledged
  21. Frank Nägler uploaded patch set 7 CR +1 V +1 09/12/24, 08:28

  22. Torben Hansen voted on patch set 7 CR +1 V +1 09/12/24, 08:30

  23. Oli Bartsch voted on patch set 7 CR +2 V +2 09/12/24, 08:31

  24. core-ci voted on patch set 7 V +1 09/12/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65542

  25. Oli Bartsch merged patch set 8 09/12/24, 09:03