83320[TASK] Deprecate ExtensionManagementUtility::addPItoST43()
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Torben Hansen +1
-
Verified V +2 Done
- Oli Bartsch +2
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 3
Review log 3441
Show 1216 earlier messages
-
Frank Nägler uploaded patch set 1 03/07/24, 20:48
-
core-ci voted on patch set 1 V +1 03/07/24, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54190
-
Georg Ringer voted on patch set 1 CR +1 V +1 03/08/24, 06:01
-
Andreas Kienast commented on patch set 1 CR -1 03/08/24, 08:23
MethodCallStaticMatcher.php:165Only the argument `$key` is mandatory.MethodCallStaticMatcher.php:166The method accepts has a total of 5 arguments. -
Christian Kuhn commented on patch set 1 03/08/24, 10:38
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36Replyyeah. this needs more information. a cross-reference is minumum, an example for "90% of cases" would be better. -
Frank Nägler uploaded patch set 2
CR +1V +109/10/24, 17:24 -
core-ci voted on patch set 2 V +1 09/10/24, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65298
-
Torben Hansen commented on patch set 2 09/10/24, 17:49
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:37I think it is better to use a cross reference here instead of a hard link (which may change). Possible cross reference (untested - needs to be verified by documentation team): ``` :ref:`Plugin Registration API <t3coreapi:extbase_registration_of_frontend_plugins>` ``` -
Frank Nägler commented on patch set 2 09/10/24, 17:52
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:37Replynever saw this before, but I will check that, thx.MethodCallStaticMatcher.php:165ReplyAcknowledgedMethodCallStaticMatcher.php:166ReplyAcknowledged -
Frank Nägler uploaded patch set 3
V +109/10/24, 17:55 -
Frank Nägler uploaded patch set 4 09/10/24, 17:56
-
Frank Nägler commented on patch set 4 09/10/24, 17:59
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:37ReplyAcknowledged -
Frank Nägler commented on patch set 4 09/10/24, 17:59
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36ReplyAcknowledged -
core-ci voted on patch set 3 V +1 09/10/24, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65305
-
core-ci voted on patch set 4 V +1 09/10/24, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65308
-
Benni Mack voted on patch set 4 CR +1 V +1 09/10/24, 18:10
-
Garvin Hicking commented on patch set 4 09/10/24, 18:17
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36Could we maybe give an example here, to allow easier migration with an example before/after? -
Torben Hansen voted on patch set 4 CR +1 V +1 09/11/24, 06:28
-
Frank Nägler commented on patch set 4 09/11/24, 07:25
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36ReplyI don't think so. We have a reference to documentation, and we know that the old function is used very rarely. I would copy example codes from the documentation. -
Lina Wolf commented on patch set 4 09/11/24, 09:19
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36ReplyEMU::addPItoST43() is however used in non-Extbase context, so linking the Extbase docs here is misleading. -
Simon Schaufelberger commented on patch set 4 CR -1 09/11/24, 19:01
ExtensionManagementUtility.php:922this is not true. it should be at least 13.3 -
Simon Schaufelberger commented on patch set 4 09/11/24, 19:02
ExtensionManagementUtility.php:927same here -
Frank Nägler commented on patch set 5
CR +1V +109/11/24, 19:45Published edit on patch set 4. -
Frank Nägler commented on patch set 5 09/11/24, 19:47
ExtensionManagementUtility.php:922ReplyDoneExtensionManagementUtility.php:927ReplyDone -
core-ci voted on patch set 5 V +1 09/11/24, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65485
-
Torben Hansen voted on patch set 5 CR +1 V +1 09/12/24, 06:15
-
Benni Mack commented on patch set 5 09/12/24, 07:36
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36Replyfrom reading the code multiple times: I think "addPItoST43" does not work if you ever use namespaced PHP classes such "Benni\MyExtension\Controller\MyController" It only ! works if you have PHP code that is called "class tx_myext_pi1" without a namespace - which also has a method called "main". This is because "addPItoST43" actually creates the TypoScript to a UserFunc with "plugin.tx_myext_pi1 = USER plugin.tx_myext_pi1.userFunc = tx_myext_pi1->main" I've searched through TER and only found places where people used the API method but then actually changed the TypoScript manually 😊 A prominent example: https://github.com/tpwd/ke_search/blob/master/ext_localconf.php#L17-L22 -
Andreas Kienast voted on patch set 5 CR +1 V +1 09/12/24, 07:50
-
Frank Nägler uploaded patch set 6
CR +1V +109/12/24, 08:14 -
Frank Nägler commented on patch set 5 09/12/24, 08:14
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36ReplyAcknowledged -
Andreas Kienast voted on patch set 6 CR +1 V +1 09/12/24, 08:14
-
Oli Bartsch voted on patch set 6 CR +1 V +1 09/12/24, 08:15
-
Garvin Hicking commented on patch set 6 CR +1 V +1 09/12/24, 08:21
Thank you ☺️ -
Garvin Hicking commented on patch set 6 09/12/24, 08:23
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:41typo missing "x", but we can "fix it in post". -
core-ci voted on patch set 6 V +1 09/12/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65537
-
Frank Nägler commented on patch set 6 09/12/24, 08:28
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:41ReplyAcknowledged -
Frank Nägler uploaded patch set 7
CR +1V +109/12/24, 08:28 -
Torben Hansen voted on patch set 7 CR +1 V +1 09/12/24, 08:30
-
Oli Bartsch voted on patch set 7 CR +2 V +2 09/12/24, 08:31
-
core-ci voted on patch set 7 V +1 09/12/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65542
-
Oli Bartsch merged patch set 8 09/12/24, 09:03
Deprecation-102821-ExtensionManagementUtilityaddPItoST43.rst:36