Review main Merged

83322[TASK] Separation of concerns while rendering Page module

Benni Mack CR +2 V +2 Hard +191 −140 updated 03/08/24, 21:39

Commit message

All PageTsConfig options are now in DrawingConfiguration
and named properly.

All plain labels are now moved to Fluid directly via <f:translate>

Random id="{uniqueId}" are removed from markup, reducing
the usages to the AbstractGridObject, which hopefully
will vanish in the near future.

RecordRememberer is a singleton and injected as much as possible.

The "languageMode" is now resolved into a PageViewMode enum.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 913

  1. Benni Mack uploaded patch set 1 03/08/24, 09:10

  2. core-ci voted on patch set 1 V -1 03/08/24, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54214

  3. Benni Mack uploaded patch set 2 V -1 03/08/24, 09:41

  4. core-ci voted on patch set 2 V +1 03/08/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54221

  5. Benni Mack uploaded patch set 3 V +1 03/08/24, 13:11

  6. core-ci voted on patch set 3 V +1 03/08/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54261

  7. Benni Mack updated the commit message in patch set 4 V +1 03/08/24, 13:59

  8. core-ci voted on patch set 4 V +1 03/08/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54264

  9. Andreas Kienast voted on patch set 4 CR +1 V +1 03/08/24, 14:31

  10. Nikita Hovratov voted on patch set 4 CR +1 V +1 03/08/24, 21:17

  11. Benni Mack commented on patch set 4 CR +1 V +1 03/08/24, 21:39

    thanks, nikita!
  12. Benni Mack voted on patch set 4 CR +2 V +2 03/08/24, 21:39

  13. Benni Mack merged patch set 5 03/08/24, 21:39