83322[TASK] Separation of concerns while rendering Page module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 22
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+13 −28
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/AbstractGridObject.php+0 −6
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/Grid.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+14 −10
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+5 −7
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+4 −22
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+2 −2
- typo3/sysext/backend/Classes/View/BackendLayout/RecordRememberer.php+1 −1
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+5 −8
- typo3/sysext/backend/Classes/View/Drawing/DrawingConfiguration.php+42 −18
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+8 −7
- typo3/sysext/backend/Classes/View/PageViewMode.phpnew+35 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+4 −4
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+4 −4
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+3 −3
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageLayout.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+1 −1
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+33 −8
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+12 −6
- typo3/sysext/core/Classes/Site/Entity/NullSite.php+1 −1
Review log 913
-
Benni Mack uploaded patch set 1 03/08/24, 09:10
-
core-ci voted on patch set 1 V -1 03/08/24, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54214
-
Benni Mack uploaded patch set 2
V -103/08/24, 09:41 -
core-ci voted on patch set 2 V +1 03/08/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54221
-
Benni Mack uploaded patch set 3
V +103/08/24, 13:11 -
core-ci voted on patch set 3 V +1 03/08/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54261
-
Benni Mack updated the commit message in patch set 4
V +103/08/24, 13:59 -
core-ci voted on patch set 4 V +1 03/08/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54264
-
Andreas Kienast voted on patch set 4 CR +1 V +1 03/08/24, 14:31
-
Nikita Hovratov voted on patch set 4 CR +1 V +1 03/08/24, 21:17
-
Benni Mack commented on patch set 4 CR +1 V +1 03/08/24, 21:39
thanks, nikita! -
Benni Mack voted on patch set 4 CR +2 V +2 03/08/24, 21:39
-
Benni Mack merged patch set 5 03/08/24, 21:39