83331[BUGFIX] workspace problem unique/uniqueInPid
Commit message
Review
-
Code review CR -1
- Benni Mack -1
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 2
Review log 914
-
Can Adrian Karadag uploaded patch set 1 03/08/24, 10:34
-
Can Adrian Karadag commented on patch set 2 03/08/24, 10:38
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 03/08/24, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54229
-
core-ci voted on patch set 2 V -1 03/08/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54230
-
Can Adrian Karadag uploaded patch set 3
V -103/08/24, 11:05 -
core-ci voted on patch set 3 V -1 03/08/24, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54236
-
Can Adrian Karadag uploaded patch set 4
V -103/08/24, 11:13 -
core-ci voted on patch set 4 V -1 03/08/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54237
-
Can Adrian Karadag rebased onto patch set 5
V -101/08/25, 16:34 -
core-ci voted on patch set 5 V -1 01/08/25, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72105
-
Benni Mack commented on patch set 5 03/04/25, 07:13
I think the new check should be a bit different to handle unique/uniqueInPid and uniqueInSite - there is issue already an issue I tried to fix in 4.5 back then. Now that workspaces got simpler in terms of data handling, we should be able to fix this: a) For versioned records, the unique check should be made against all live records and all records within the same workspace (except the t3ver_oid record during update) - this should be for new + updated records b) On publishing we need a "preflight" check to see if the records can be published or if there is an issue because a live record might have changed the uniqueInPid in live which would then be a conflict. -
Benni Mack voted on patch set 5 CR -1 03/04/25, 07:13
-
Benni Mack marked it work in progress 03/04/25, 07:13
-
Benni Mack abandoned the change 10/15/26, 06:01
Should be fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/95634