Review 12.4 Merged

83332[DOCS] Fix Edit on GitHub Button for manuals

Lina Wolf CR +2 V +2 Easy +10 −1 updated 03/08/24, 07:54

Commit message

The setting edit-on-github-directory is needed to find the correct
directory in the monorepository.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
  • Verified V +2 Done
    • Lina Wolf +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 69

  1. Lina Wolf commented on patch set 1 03/07/24, 17:48

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/adminpanel/Documentation/guides.xml * typo3/sysext/dashboard/Documentation/guides.xml * typo3/sysext/felogin/Documentation/guides.xml * typo3/sysext/fluid_styled_content/Documentation/guides.xml * typo3/sysext/impexp/Documentation/guides.xml * typo3/sysext/indexed_search/Documentation/guides.xml * typo3/sysext/linkvalidator/Documentation/guides.xml
  2. core-ci voted on patch set 1 V +1 03/07/24, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54162

  3. Lina Wolf uploaded patch set 2 V +1 03/08/24, 07:44

  4. Lina Wolf uploaded patch set 3 03/08/24, 07:45

  5. Lina Wolf marked it ready for review 03/08/24, 07:45

  6. core-ci voted on patch set 2 V +1 03/08/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54205

  7. core-ci voted on patch set 3 V +1 03/08/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54206

  8. Lina Wolf voted on patch set 3 CR +2 V +2 03/08/24, 07:54

  9. Lina Wolf merged patch set 4 03/08/24, 07:54