Review main Merged

83353[DOCS] Switch styleguide documentation to PHP-based rendering

Lina Wolf CR +2 V +2 Easy +11 −8 updated 03/08/24, 16:57

Commit message

* Introduce a guides.xml, the presence of this file
  triggers the new rendering.
* Remove outdated genindex: not supported anymore
* Remove old Settings.cfg, was only used for Sphinx

Attention: Backport needs manual changes to the guides.xml.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Chris Müller +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Lina Wolf uploaded patch set 1 03/08/24, 10:54

  2. core-ci voted on patch set 1 V +1 03/08/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54234

  3. Chris Müller commented on patch set 1 CR -1 03/08/24, 11:35

    Do we really need this nothing-saying Documentation/Index.rst? I opt for removing the Documentation folder altogether - it has no value. Additionally, there is no 12.4 or 11.5 version in this repo.
  4. Lina Wolf updated the commit message in patch set 2 CR -1 V +1 03/08/24, 11:58

  5. Lina Wolf commented on patch set 2 03/08/24, 11:59

    Reply

    Good hint, I removed the backport. My plan would be to use the current README.md in the future. However in the current situation I only want to migrate the content that is currently there. We can still make a follow-up
  6. core-ci voted on patch set 2 V +1 03/08/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54241

  7. Chris Müller commented on patch set 2 03/08/24, 13:14

    Reply

    Why migrating when then dropping? You can drop it now.
  8. Lina Wolf commented on patch set 2 03/08/24, 16:00

    Reply

    My plan is not to drop it but to migrate the content that is currently in the README. But that should be done in a follow-up.
  9. Chris Müller commented on patch set 2 CR +1 V +1 03/08/24, 16:56

    Reply

    Acknowledged
  10. Lina Wolf voted on patch set 2 CR +2 V +2 03/08/24, 16:57

  11. Lina Wolf merged patch set 3 03/08/24, 16:57