Review main Merged

83355[TASK] Replace sql int casts with `ExpressionBuilder::castInt()`

Stefan Bürk CR +2 V +2 Easy +18 −15 updated 03/08/24, 13:16

Commit message

Since #98503 the new TypoScript parser is used
in the frontend, which used a value list trick
to minimize database queries. That required to
do proper value casting for each list element,
which has been implementend manually with dbms
vendor aware handling.

Recently #103309 enriched the `ExpressionBuilder`
with a couple of additional expression methods,
including `castInt()` expression.

This change replaces the manual db aware integer
casting with the new `ExpressionBuilder::castInt()`
method within the TypoScript parser classes along
with the corresponding `@todo` marker.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1