Review main Merged

83362[TASK] Streamline Backend Layout View code

Benni Mack CR +2 V +2 Hard +136 −323 updated 06/13/24, 16:11

Commit message

This change adapts some places around Backend Layouts,
which is a pre-patch in order to centralize
previously used code from 2013 to move towards a more
generic concept, which needs to go into EXT:core
as the structure should also be useful and evaluated
in EXT:frontend.

This change now cleans up places which are non-breaking
but hardens PHP code without changing the underlying
logic.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1317

  1. Benni Mack uploaded patch set 1 03/08/24, 21:42

  2. core-ci voted on patch set 1 V -1 03/08/24, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54311

  3. Oliver Hader uploaded patch set 2 V -1 03/11/24, 17:30

  4. Oliver Hader commented on patch set 2 03/11/24, 17:32

    Moved view test to functional for having the possibility to "mock" the root-line... In the longterm either root-line resolving would be an (injectable) service and/or the whole test would use real backend layout fixtures (not just mocks)...
  5. core-ci voted on patch set 2 V +1 03/11/24, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54381

  6. Benni Mack updated the commit message in patch set 3 V +1 03/11/24, 22:48

  7. core-ci voted on patch set 3 V +1 03/11/24, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54385

  8. Andreas Kienast voted on patch set 3 CR +1 03/12/24, 07:43

  9. Oli Bartsch uploaded patch set 4 CR +1 V +1 03/13/24, 09:43

  10. Oli Bartsch voted on patch set 4 CR +1 V +1 03/13/24, 09:43

  11. core-ci voted on patch set 4 V +1 03/13/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54463

  12. Andreas Kienast voted on patch set 4 CR +2 V +2 03/13/24, 11:17

  13. Andreas Kienast merged patch set 5 03/13/24, 11:17

  14. Nikita Hovratov commented on patch set 5 04/24/24, 07:16

    BackendLayout.php:3

    Actually breaking change. In the Mask extension I passed some uid of a backend layout to the constructor. Due to strict type, I got hard error.
  15. Benni Mack commented on patch set 5 04/24/24, 07:18

    BackendLayout.php:3 Reply

    Thanks for the info. Should we revert this part?
  16. Nikita Hovratov commented on patch set 5 04/24/24, 10:19

    BackendLayout.php:3 Reply

    Not sure if this is used so often. Mask is a bit special. But to adhere to our breaking changes policies, the strict typing should be removed at least. We could also do a search in TER and decide according to the findings.
  17. Benni Mack commented on patch set 5 06/13/24, 16:11

    BackendLayout.php:3 Reply