83362[TASK] Streamline Backend Layout View code
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php4+24 −92
- typo3/sysext/backend/Classes/View/BackendLayout/DataProviderCollection.php+10 −24
- typo3/sysext/backend/Classes/View/BackendLayout/DataProviderContext.php+16 −63
- typo3/sysext/backend/Classes/View/BackendLayout/DefaultDataProvider.php+12 −22
- typo3/sysext/backend/Classes/View/BackendLayout/PageTsBackendLayoutDataProvider.php+4 −18
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+41 −89
- typo3/sysext/backend/Tests/Functional/View/BackendLayoutViewTest.phprenamed+29 −15
Review log 1317
-
Benni Mack uploaded patch set 1 03/08/24, 21:42
-
core-ci voted on patch set 1 V -1 03/08/24, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54311
-
Oliver Hader uploaded patch set 2
V -103/11/24, 17:30 -
Oliver Hader commented on patch set 2 03/11/24, 17:32
Moved view test to functional for having the possibility to "mock" the root-line... In the longterm either root-line resolving would be an (injectable) service and/or the whole test would use real backend layout fixtures (not just mocks)... -
core-ci voted on patch set 2 V +1 03/11/24, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54381
-
Benni Mack updated the commit message in patch set 3
V +103/11/24, 22:48 -
core-ci voted on patch set 3 V +1 03/11/24, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54385
-
Andreas Kienast voted on patch set 3 CR +1 03/12/24, 07:43
-
Oli Bartsch uploaded patch set 4
CR +1V +103/13/24, 09:43 -
Oli Bartsch voted on patch set 4 CR +1 V +1 03/13/24, 09:43
-
core-ci voted on patch set 4 V +1 03/13/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54463
-
Andreas Kienast voted on patch set 4 CR +2 V +2 03/13/24, 11:17
-
Andreas Kienast merged patch set 5 03/13/24, 11:17
-
Nikita Hovratov commented on patch set 5 04/24/24, 07:16
BackendLayout.php:3Actually breaking change. In the Mask extension I passed some uid of a backend layout to the constructor. Due to strict type, I got hard error. -
Benni Mack commented on patch set 5 04/24/24, 07:18
BackendLayout.php:3ReplyThanks for the info. Should we revert this part? -
Nikita Hovratov commented on patch set 5 04/24/24, 10:19
BackendLayout.php:3ReplyNot sure if this is used so often. Mask is a bit special. But to adhere to our breaking changes policies, the strict typing should be removed at least. We could also do a search in TER and decide according to the findings. -
Benni Mack commented on patch set 5 06/13/24, 16:11
BackendLayout.php:3ReplySee https://review.typo3.org/c/Packages/TYPO3.CMS/+/84701 as followup