Review main Merged

83394[DOCS] Put example input in backtics in form manual

Lina Wolf CR +2 V +2 Easy +14 −14 updated 03/09/24, 18:24

Commit message

This prevents warnings during rendering and also looks better.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Chris Müller +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Lina Wolf uploaded patch set 1 03/09/24, 16:55

  2. core-ci voted on patch set 1 V +1 03/09/24, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54327

  3. Chris Müller commented on patch set 1 03/09/24, 17:24

    Please explain the reason for this? Are warnings thrown on rendering?
  4. Lina Wolf updated the commit message in patch set 2 V +1 03/09/24, 17:25

  5. Lina Wolf commented on patch set 2 03/09/24, 17:27

    Reply

    Oh, my description was missing, yes as text between pipes is interpreted as variable it causes warnings when that variable is not found. while at it I also put the other example inputs in backtics
  6. core-ci voted on patch set 2 V +1 03/09/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54331

  7. Chris Müller commented on patch set 2 03/09/24, 17:49

    Index.rst:58

    Hmm, either this should be [A-Za-z0-9] as it looks like a regex, or something like "A-Z" and "0-9" so be more literal.

    Index.rst:146

    At least, this should be [0-9\.e+-], although this is technically not really correct: The string "0e+3e5" is not a float but would be valid according to the regex.
  8. Lina Wolf commented on patch set 2 03/09/24, 17:53

    Index.rst:58 Reply

    All i did was add the backtics for optics and rendering.. such a change would be beyond the scope of this change. But feel free to make a follow up. There are countless places in this ticket needing some love.

    Index.rst:146 Reply

    All i did was add the backtics for optics and rendering.. such a change would be beyond the scope of this change. But feel free to make a follow up. There are countless places in this ticket needing some love.
  9. Lina Wolf commented on patch set 2 03/09/24, 17:54

    Index.rst:58 Reply

    Acknowledged

    Index.rst:146 Reply

    Acknowledged
  10. Chris Müller voted on patch set 2 CR +1 V +1 03/09/24, 18:24

  11. Lina Wolf voted on patch set 2 CR +2 V +2 03/09/24, 18:24

  12. Lina Wolf merged patch set 3 03/09/24, 18:24