83403[BUGFIX] Drag-and-drop CEs without selecting text-nodes
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 2
Files 2
Review log 2937
Show 812 earlier messages
-
Ayke Halder uploaded patch set 1 03/11/24, 14:02
-
core-ci voted on patch set 1 V +1 03/11/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54365
-
Ayke Halder updated the commit message in patch set 2
V +103/11/24, 14:09 -
Ayke Halder updated the commit message in patch set 3 03/11/24, 14:10
-
core-ci voted on patch set 2 V +1 03/11/24, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54366
-
core-ci voted on patch set 3 V +1 03/11/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54367
-
Ayke Halder updated the commit message in patch set 4
V +103/13/24, 11:20 -
core-ci voted on patch set 4 V +1 03/13/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54471
-
Christian Rath-Ulrich voted on patch set 4 CR +1 V +1 07/17/24, 15:30
-
Georg Ringer voted on patch set 4 CR +1 V +1 07/18/24, 04:49
-
Benjamin Kott commented on patch set 4 CR -1 07/18/24, 06:46
this patch has a merge conflict. -
Ayke Halder uploaded patch set 5
CR +1V +107/18/24, 07:31
-
Ayke Halder commented on patch set 5 CR +1 V +1 07/18/24, 07:36
Merge conflict was only in the generated CSS `backend.css`. Is there a way to update changes like this automatically if the merge conflict only exists in generated code? -
core-ci voted on patch set 5 V -1 07/18/24, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61722
-
Ayke Halder voted on patch set 5 CR 0 V 0 07/18/24, 08:10
-
core-ci voted on patch set 5 V +1 07/18/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61722
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 07/18/24, 08:37
-
Benjamin Kott commented on patch set 5 07/18/24, 08:37
Reply
we already mitigated the issue, so it´s way better than before. but you probably need to rebase every commit after a merge. -
Ayke Halder commented on patch set 5 07/18/24, 09:08
Reply
Acknowledged -
Benjamin Kott commented on patch set 5 CR -1 V -1 07/18/24, 09:44
_page.scss:70The selector is far too greedy, it disables text selection in the complete page module. I cannot reproduce the issue on chrome and firefox - the page module drag drop was cleaned up and it seems to be resolved by setting the header to draggable = true. -
Benjamin Kott commented on patch set 5 07/18/24, 09:46
_page.scss:70ReplyI can however reproduce the issue on v12. It a patch fixing this should only target v12 then as there is no issue on main. Still the solution seems to be wrong here. -
Benni Mack updated the commit message in patch set 6
CR +1V +110/18/24, 13:38 -
Benni Mack commented on patch set 6 11/15/24, 08:47
anyone updating the patch? I think Benjamin's comments are valid. -
Simon Schaufelberger commented on patch set 6 12/06/24, 12:28
_page.scss:70Reply@mail@ayke-halder.de would you please have a look here again? -
Ayke Halder commented on patch set 6 12/06/24, 13:43
_page.scss:70Reply@benjamin.kott@outlook.com @benni@typo3.org: What is the exact context under which I can have a look at this again? * Is this issue a Task, Bugfix or Feature? * Does a fix potentially get merged especially into TYPO3 v12 or not? -
Benni Mack commented on patch set 6 12/13/24, 17:04
_page.scss:70Replyright now, I cannot test this change easily because there is a merge conflict. In order to evaluate if this is a critical issue (so it will go in v12) or a regular bugfix (so it goes in v13) I wanted to test this and have no merge conflict when I apply this patch. Thus: The question from Benjamin Kott was in July if you can rebase the patch please? I picked this question up on Nov 15. -
Benni Mack wrote 12/13/24, 17:04
Removed cc Benni Mack. -
Simon Schaufelberger commented on patch set 6 12/13/24, 17:09
_page.scss:70ReplyWhy do you want to apply this patch? You can also just check it out in the old version and it will work. -
Benni Mack commented on patch set 6 12/13/24, 19:43
_page.scss:70Reply@simonschaufi+typo3@gmail.com maybe I don't understand what you mean, but this is what I do - Gerrit: I click on "Download patch" - Gerrit: I click on "Cherry pick" I paste this in my terminal: ➜ Core git:(main) git fetch ssh://benni@review.typo3.org:29418/Packages/TYPO3.CMS refs/changes/03/83403/6 && git cherry-pick FETCH_HEAD remote: Counting objects: 20093, done remote: Finding sources: 100% (14/14) remote: Total 14 (delta 0), reused 5 (delta 0) Unpacking objects: 100% (14/14), 74.47 KiB | 990.00 KiB/s, done. From ssh://review.typo3.org:29418/Packages/TYPO3.CMS * branch refs/changes/03/83403/6 -> FETCH_HEAD Auto-merging Build/Sources/Sass/module/_page.scss Auto-merging typo3/sysext/backend/Resources/Public/Css/backend.css CONFLICT (content): Merge conflict in typo3/sysext/backend/Resources/Public/Css/backend.css error: could not apply b9137c58452... [BUGFIX] Drag-and-drop CEs without selecting text-nodes hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ----------------------------------- To give you an answer to your question "Why do you want to apply the patch?": I asked to rebase the patch so the patch applies cleanly on the latest main, so a) I can test this one on latest main and b) so CI runs through again to c) eventually vote for it. -
Simon Schaufelberger commented on patch set 6 12/13/24, 22:17
_page.scss:70ReplyWell, you can use "checkout branch" and then rebase the code locally from origin/main and push it again. I did that now for you. -
Simon Schaufelberger uploaded patch set 7 12/13/24, 22:19
-
core-ci voted on patch set 7 V +1 12/13/24, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71080
-
Simon Schaufelberger uploaded patch set 8
V +105/05/25, 22:03 -
core-ci voted on patch set 8 V +1 05/05/25, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78561
-
Benni Mack wrote 05/05/25, 22:21
Removed cc Benni Mack. -
Simon Schaufelberger commented on patch set 8 05/05/25, 22:44
_page.scss:70Reply UnresolvedI did another round of testing and it looks like the issue doesn't appear on main branch anymore (without the patch) as the dragged ce is not the same as the original anymore but another object with a different layout. This problem only occurs on TYPO3 12. TYPO3 13 is ok. -
Garvin Hicking abandoned the change 08/04/25, 09:54
See review comment plus closed ticket https://forge.typo3.org/issues/103359