83405[TASK] Streamline tests in ImageViewHelperTest
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Jasmina Ließmann +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jasmina Ließmann +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 78
-
Oliver Hader uploaded patch set 1 03/11/24, 15:04
-
Christian Kuhn voted on patch set 1 CR +1 V +1 03/11/24, 15:10
-
core-ci voted on patch set 1 V +1 03/11/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54371
-
Benjamin Franzke commented on patch set 1 03/11/24, 15:13
-
Jasmina Ließmann voted on patch set 1 CR +1 V +1 03/11/24, 15:15
-
Christian Kuhn commented on patch set 1 03/11/24, 15:16
ImageViewHelperTest.php:202Replyi don't care too much: we can as well just fix the values together with the incoming bugfix. -
Benjamin Franzke commented on patch set 1 CR +2 V +2 03/11/24, 15:18
ImageViewHelperTest.php:202ReplyAck -
Benjamin Franzke merged patch set 2 03/11/24, 15:18
ImageViewHelperTest.php:202