Review main Merged

83405[TASK] Streamline tests in ImageViewHelperTest

Oliver Hader CR +2 V +2 Easy +42 −6 updated 03/11/24, 15:18

Commit message

* rename `masked` to `inline-max`
* add tests for image upscaling

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 03/11/24, 15:04

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 03/11/24, 15:10

  3. core-ci voted on patch set 1 V +1 03/11/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54371

  4. Benjamin Franzke commented on patch set 1 03/11/24, 15:13

    ImageViewHelperTest.php:202

    should we disable this one until the patch that actually ensured that image is not upscaled? > 83299: [TASK] Avoid duplicate image crop (crop-crop-scale to crop-scale) | https://review.typo3.org/c/Packages/TYPO3.CMS/+/83299 ..because with this patch this described the wrong state …or mark with (@todo: values are wrong, upscaling not yet avoided) in order to remove that comment with the next patch
  5. Jasmina Ließmann voted on patch set 1 CR +1 V +1 03/11/24, 15:15

  6. Christian Kuhn commented on patch set 1 03/11/24, 15:16

    ImageViewHelperTest.php:202 Reply

    i don't care too much: we can as well just fix the values together with the incoming bugfix.
  7. Benjamin Franzke commented on patch set 1 CR +2 V +2 03/11/24, 15:18

    ImageViewHelperTest.php:202 Reply

    Ack
  8. Benjamin Franzke merged patch set 2 03/11/24, 15:18