Review main Merged

83408[TASK] Remove leftover query parsing code in cObj

Benni Mack CR +2 V +2 Normal +45 −170 updated 03/13/24, 07:23

Commit message

Some code in ContentObjectRenderer is not needed
anymore as the query parts are not parsed anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1521

  1. Benni Mack uploaded patch set 1 03/11/24, 23:09

  2. core-ci voted on patch set 1 V -1 03/11/24, 23:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54388

  3. Benni Mack uploaded patch set 2 V -1 03/12/24, 08:07

  4. core-ci voted on patch set 2 V -1 03/12/24, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54397

  5. Benni Mack uploaded patch set 3 V -1 03/12/24, 08:24

  6. core-ci voted on patch set 3 V -1 03/12/24, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54400

  7. Benni Mack uploaded patch set 4 V -1 03/12/24, 09:38

  8. core-ci voted on patch set 4 V +1 03/12/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54406

  9. Benni Mack updated the commit message in patch set 5 V +1 03/12/24, 09:59

  10. Andreas Kienast commented on patch set 5 03/12/24, 10:03

    ContentObjectRenderer.php:4779

    AFAICS we can pass `$connection` here as well.
  11. core-ci voted on patch set 5 V +1 03/12/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54409

  12. Andreas Kienast commented on patch set 5 03/12/24, 10:09

    ContentObjectRenderer.php:4779 Reply

    This would also make the `$table` argument superfluous, it's only needed for the ConnectionPool instantiation.
  13. Andreas Kienast uploaded patch set 6 V +1 03/12/24, 10:10

  14. Andreas Kienast commented on patch set 6 03/12/24, 10:15

    ContentObjectRenderer.php:4779 Reply

    Done
  15. core-ci voted on patch set 6 V +1 03/12/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54411

  16. Andreas Kienast voted on patch set 6 CR +1 V +1 03/12/24, 10:17

  17. Stefan Bürk voted on patch set 6 CR +1 V +1 03/12/24, 13:42

  18. Oli Bartsch voted on patch set 6 CR +1 V +1 03/12/24, 17:19

  19. Christian Kuhn voted on patch set 6 CR +1 V +1 03/13/24, 07:09

  20. Benni Mack voted on patch set 6 CR +2 V +2 03/13/24, 07:23

  21. Benni Mack merged patch set 7 03/13/24, 07:23