Review main Merged

83433[BUGFIX] Add server request to view in ConfirmationFinisher

Christoph Lehmann CR +2 V +2 Easy +3 −7 updated 03/12/24, 17:14

Commit message

Since #98377 it is not possible to use `f:link.page`
ViewHelper in the ConfirmationFinisher template.

This adds the server request to the standalone view
to make it work again.

Also removed wrong comment and direct usage of global
request object.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Christoph Lehmann uploaded patch set 1 03/12/24, 09:26

  2. Christoph Lehmann commented on patch set 1 03/12/24, 09:28

    This is the only Finisher, that uses the StandaloneView
  3. Mathias Brodala commented on patch set 1 03/12/24, 09:31

    Reply

    Actually also the EmailFinisher does, but it already sets the request on the view. But interestingly not from the FormRuntime but from globals. Maybe ask in the TYPO3 Slack about this; IMO this should be unified.
  4. core-ci voted on patch set 1 V +1 03/12/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54404

  5. Stefan Bürk commented on patch set 1 03/12/24, 09:38

    ConfirmationFinisher.php:129

    I'd say we should better use ``` $standaloneView->getRenderingContext()->setRequest(...) ``` directly here - what do you think ?
  6. Christoph Lehmann uploaded patch set 2 V +1 03/12/24, 11:55

  7. Christoph Lehmann commented on patch set 2 03/12/24, 11:58

    Reply

    I unified it.

    ConfirmationFinisher.php:129 Reply

    Done
  8. core-ci voted on patch set 2 V -1 03/12/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54421

  9. Christoph Lehmann uploaded patch set 3 V -1 03/12/24, 12:13

  10. Christoph Lehmann commented on patch set 2 03/12/24, 12:15

    ConfirmationFinisher.php:129 Reply

    Switched back to it. $standaloneView->setRequest() is also used at other places.
  11. core-ci voted on patch set 3 V +1 03/12/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54423

  12. Stefan Bürk updated the commit message in patch set 4 V +1 03/12/24, 13:24

  13. Stefan Bürk voted on patch set 4 CR +1 V +1 03/12/24, 13:27

  14. core-ci voted on patch set 4 V +1 03/12/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54435

  15. Oli Bartsch voted on patch set 4 CR +2 V +2 03/12/24, 17:14

  16. Oli Bartsch merged patch set 5 03/12/24, 17:14