83434[BUGFIX] Allow adding multiple files / folders via element browser
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/filelist/browse-files.ts+2 −1
- Build/Sources/TypeScript/filelist/browse-folders.ts+2 −1
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+2 −1
- Build/Sources/TypeScript/filelist/file-list-actions.ts+2 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/browse-files.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/browse-folders.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-actions.js+1 −1
Review log 1219
-
Oli Bartsch uploaded patch set 1 03/12/24, 09:46
-
core-ci voted on patch set 1 V -1 03/12/24, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54407
-
Oli Bartsch uploaded patch set 2
V -103/12/24, 12:50 -
core-ci voted on patch set 2 V -1 03/12/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54431
-
Oli Bartsch uploaded patch set 3
V -103/12/24, 13:49 -
core-ci voted on patch set 3 V -1 03/12/24, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54436
-
Oli Bartsch uploaded patch set 4
V -103/12/24, 16:50 -
core-ci voted on patch set 4 V +1 03/12/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54440
-
Garvin Hicking commented on patch set 4 03/13/24, 10:12
I think this is great for multi-file insertions; but if you have a TCA that only allows a single image/reference, not closing the modal feels "wrong". I'm not sure though if JS can make a distinction if a modal was opened with a TCA limit=1 or multiple allowances? How about closing the modal if I click on the image title, but leaving it open when I click on the "+"? The "+" is IMO always an intent to add more than just one image. Then again, UI-wise this might be confusing. -
Oli Bartsch uploaded patch set 5
V +103/13/24, 13:46 -
core-ci voted on patch set 5 V -1 03/13/24, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54481
-
Oli Bartsch uploaded patch set 6
V -103/13/24, 14:01 -
core-ci voted on patch set 6 V -1 03/13/24, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54482
-
Oli Bartsch commented on patch set 6 03/13/24, 14:08
Reply
Sounds good. Implemented the logic to close the modal on filename click but keep it open using the "+" button (no matter whether there is a limit set). I think this is the most understandable way for editors. -
core-ci voted on patch set 6 V +1 03/13/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54482
-
Jochen Roth voted on patch set 6 CR +1 V +1 03/13/24, 14:37
-
Andreas Kienast commented on patch set 6 CR +1 V +1 03/13/24, 15:30
The only thing I dislike is that the patch cannot respect a potentially configured `maxitems`, which is already an issue with the mass import feature anyway. -
Oli Bartsch voted on patch set 6 CR +2 V +2 03/13/24, 18:28
-
Oli Bartsch merged patch set 7 03/13/24, 18:33