Review main Merged

83437[TASK] Implement `@typescript-eslint/prefer-string-starts-ends-with` rule

Andreas Kienast CR +2 V +2 Easy +11 −10 updated 03/14/24, 07:27

Commit message

The eslint configuration now takes the rule
`@typescript-eslint/prefer-string-starts-ends-with` [1] into account,
enforcing the usage of `startsWith()` and `endWith()` over index
checking in strings.

[1] https://typescript-eslint.io/rules/prefer-string-starts-ends-with

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 67

  1. Andreas Kienast uploaded patch set 1 03/12/24, 10:51

  2. core-ci voted on patch set 1 V +1 03/12/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54414

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 03/12/24, 21:14

  4. Benjamin Franzke voted on patch set 1 CR +1 03/13/24, 07:39

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 03/14/24, 07:24

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 03/14/24, 07:25

  7. Andreas Kienast merged patch set 2 03/14/24, 07:27