Review main Merged

83438[TASK] Implement `@typescript-eslint/no-array-delete` rule

Andreas Kienast CR +2 V +2 Easy +11 −10 updated 03/12/24, 13:09

Commit message

The eslint configuration now takes the rule
`@typescript-eslint/no-array-delete` [1] into account, prohibiting
element removal from an array via `delete`. The problem with `delete` is
that the element to be removed is in fact replaced with an `empty` slot,
effectible keeping the array's size. Using `splice()` [2] is the
preferred way to remove elements from an array.

[1] https://typescript-eslint.io/rules/no-array-delete/
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 810

  1. Andreas Kienast uploaded patch set 1 03/12/24, 11:05

  2. core-ci voted on patch set 1 V +1 03/12/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54415

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 03/12/24, 11:21

  4. Andreas Kienast uploaded patch set 2 CR +1 V +1 03/12/24, 12:02

  5. core-ci voted on patch set 2 V +1 03/12/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54422

  6. Benjamin Franzke voted on patch set 2 CR +1 03/12/24, 12:17

  7. Benjamin Franzke voted on patch set 2 V +1 03/12/24, 12:20

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 03/12/24, 12:39

  9. Andreas Kienast voted on patch set 2 CR +2 V +2 03/12/24, 12:55

  10. Andreas Kienast merged patch set 3 03/12/24, 13:09