Review main Merged

83439[TASK] Implement `@typescript-eslint/restrict-plus-operands` rule

Andreas Kienast CR +2 V +2 Easy +7 −6 updated 03/13/24, 07:32

Commit message

The eslint configuration now takes the rule
`@typescript-eslint/restrict-plus-operands` [1] into account,
prohibiting merging of type-incompatible operands.

[1] https://typescript-eslint.io/rules/restrict-plus-operands

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Andreas Kienast uploaded patch set 1 03/12/24, 11:45

  2. core-ci voted on patch set 1 V +1 03/12/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54418

  3. Andreas Kienast uploaded patch set 2 V +1 03/12/24, 13:11

  4. core-ci voted on patch set 2 V +1 03/12/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54434

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 03/12/24, 17:22

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 03/12/24, 21:16

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 03/13/24, 07:23

  8. Andreas Kienast merged patch set 3 03/13/24, 07:32