Review 12.4 Merged

83440[TASK] Streamline userid/username handling and system-maintainer checks

Oliver Hader CR +2 V +2 Normal +71 −58 updated 03/12/24, 12:03

Commit message

The new methods AbstractUserAuthentication::getUserName() and
AbstractUserAuthentication::getUserId() can be used to resolve
the corresponding values (instead of using the $user->user array).

In addition, the pure system-maintainer checks have been moved into
to central BackendUserAuthentication::isSystemMaintainer(). The term
"pure" refers to ignoring the development context and not applying
any fallbacks in case the setting is empty.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 19

Review log 34

  1. Oliver Hader uploaded patch set 1 03/12/24, 11:49

  2. core-ci voted on patch set 1 V +1 03/12/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54419

  3. Oliver Hader voted on patch set 1 CR +2 V +2 03/12/24, 12:03

  4. Oliver Hader merged patch set 2 03/12/24, 12:03