83441[BUGFIX] Stop event propagation when clicking icon in page tree
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Sven Juergens +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1518
-
Andreas Kienast uploaded patch set 1 03/12/24, 12:18
-
Oliver Hader commented on patch set 1 03/12/24, 12:22
Same applies to event propagation on `file-list-action.ts` -
core-ci voted on patch set 1 V +1 03/12/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54424
-
Oliver Hader commented on patch set 1 03/12/24, 12:28
I'd rather allow event propagation for `svg-tree` and `file-list-action` again for the `contextmenu` event. -
Oliver Hader commented on patch set 1 03/12/24, 12:28
Reply
Acknowledged -
Oliver Hader commented on patch set 1 03/12/24, 12:32
Reply
Forget that, I have to read the previous patch and problem to be solved carefully again... -
Andreas Kienast updated the commit message in patch set 2
V +103/12/24, 12:33 -
Andreas Kienast updated the commit message in patch set 3 03/12/24, 12:36
-
core-ci voted on patch set 2 V +1 03/12/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54426
-
Benjamin Franzke voted on patch set 3 CR +1 03/12/24, 12:40
-
core-ci voted on patch set 3 V +1 03/12/24, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54428
-
Oliver Hader commented on patch set 3 V +1 03/12/24, 12:42
Works, but I cannot explain to myself why... -
Benjamin Franzke voted on patch set 3 V +1 03/12/24, 12:52
-
Benjamin Franzke commented on patch set 3 03/12/24, 13:00
Reply
The issue is that context-menu has a global (left)click handler that does two things: * opening * closing The closing part is broken, as it is triggered in case the ContextMenu is opened by API (`ContextMenu.show()`) from a click-handler itself. In that case hideAll is called: https://github.com/TYPO3/typo3/blob/6055db0be52bb510617e41ebb16ead15a1c71712/Build/Sources/TypeScript/backend/context-menu.ts#L227 `stopImmediatePropagartion` prevents that and that's why it didn't broke it `main` We'd like to refactor the context-menu to handle the closing part in a separate event handler (later on), but for now this patch should streamline 12.4 with the current (working) state in 12.4 -
Oliver Hader commented on patch set 3 CR +1 03/12/24, 13:16
Reply
Thx for the explanation! I compared that to the v13 implementation in `tree.ts` -
Sven Juergens voted on patch set 3 V +1 03/12/24, 13:44
-
Andreas Kienast voted on patch set 3 CR +2 V +2 03/12/24, 13:58
-
Andreas Kienast merged patch set 4 03/12/24, 13:58