Review main Abandoned

83442[FEATURE] Introduce JoinViewHelper to Fluid

Benjamin Kott CR 0 V 0 Hard +348 −0 updated 03/14/24, 15:12

Commit message

The JoinViewHelper combines elements from an array into a single string.
You can specify both a general separator and a special one for the last
element, which serves as the delimiter between the elements.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1317

  1. Benjamin Kott uploaded patch set 1 03/12/24, 12:30

  2. Benjamin Kott uploaded patch set 2 03/12/24, 12:34

  3. Mathias Brodala commented on patch set 1 03/12/24, 12:34

    Please take into account the discussion which happened here and consider adding this to Fluid Standalone instead: https://github.com/TYPO3/Fluid/pull/856
  4. core-ci voted on patch set 1 V -1 03/12/24, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54425

  5. Benjamin Kott commented on patch set 2 03/12/24, 12:38

    Reply

    ack. I will handle this as before - adding to the main - if interested in a standalone, anyone can move it over.
  6. Benjamin Kott uploaded patch set 3 03/12/24, 12:39

  7. core-ci voted on patch set 2 V -1 03/12/24, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54427

  8. Benjamin Kott commented on patch set 3 03/12/24, 12:43

    Reply

    regarding the naming, we had a discussion here, bloating the namespaces and making the templates longer and harder to read has no benefit. so we opted in for NOT moving it to a sub directory.
  9. Benjamin Franzke commented on patch set 3 03/12/24, 12:47

    Reply Unresolved

    +1 for avoiding unneeded namespaces for this kind of first-level utility
  10. core-ci voted on patch set 3 V -1 03/12/24, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54429

  11. Benjamin Kott uploaded patch set 4 V -1 03/12/24, 12:48

  12. core-ci voted on patch set 4 V +1 03/12/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54430

  13. Simon Praetorius commented on patch set 4 CR -2 03/12/24, 16:11

    ViewHelpers without TYPO3 dependencies should be part of Standalone Fluid
  14. Benjamin Kott commented on patch set 4 03/12/24, 16:15

    Reply

    I am fine, with moving it directly to fluid. but I am not willing to wait till next year. https://github.com/TYPO3/Fluid/pull/856 has been on the board for 3 months. And we still lack parity in that area to other systems. Feel free to move the patch over to fluid, but we need this and more starting April (v13). I am still compiling a list of essentials.
  15. Simon Praetorius commented on patch set 4 03/12/24, 16:23

    Reply

    Well, if only a handful of people contribute and review over at GitHub, this won't get better. I'm willing to implement more ViewHelpers there and create releases more regularly, but then there should also be people willing to review and to give feedback.
  16. Benjamin Kott commented on patch set 4 03/12/24, 20:35

    Reply Unresolved

    I get that, but if thats the problem - we should discuss dissolving fluid as a standalone product and merge it into the core.
  17. Benjamin Kott abandoned the change 03/14/24, 15:12