Review main Merged

83444[BUGFIX] Ensure that relative target link can be set in EXT:redirects

Stefan Bürk CR +2 V +2 Normal +208 −6 updated 04/21/24, 11:48

Commit message

The TYPO3 system extension `redirects` now fully supports the setting
of relative links as the `target` URL, which is a documented feature.

Previously, an issue arose when attempting to use path links with
leading slashes as URLs. This issue has been addressed in #101083,
marking the initial step toward resolving the problem of relative
target links.

Additionally, the fix now allows for linking to arbitrary resources,
even those that do not currently exist in the File Abstraction Layer
(FAL).

The class `TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter`
has been changed to limit the handling of arbitrary resources
to the smallest scope to reuse existing code and to use them
as `LinkService::TYPE_URL` links.

The superflous outer catch block has been removed to remove
dead code. In addition, a test for coverage has been added
that covers DataHandler and the lower LinkHandling layer.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 3852

Show 1827 earlier messages
  1. Stefan Bürk uploaded patch set 1 03/12/24, 14:45

  2. core-ci voted on patch set 1 V +1 03/12/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54437

  3. Stefan Bürk uploaded patch set 2 V +1 03/13/24, 09:53

  4. core-ci voted on patch set 2 V +1 03/13/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54465

  5. Stefan Bürk uploaded patch set 3 V +1 03/13/24, 11:19

  6. core-ci voted on patch set 3 V +1 03/13/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54470

  7. Oliver Hader commented on patch set 3 CR -1 03/15/24, 09:55

    The problem is not in `DataHandler`...
  8. Oliver Hader uploaded patch set 4 CR -1 V +1 03/15/24, 10:04

  9. core-ci voted on patch set 4 V +1 03/15/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54574

  10. Oliver Hader commented on patch set 4 03/15/24, 10:40

    @Stefan: After investigating, I've added some notes to https://forge.typo3.org/issues/103387#note-4 > **tl;dr: Using arbitrary (non-FAL) resources did not work before, there was no regression.** I'm leaving the rest of this patch to you. Just let me know in case you need additional feedback or support. Thx! 👍
  11. Stefan Bürk commented on patch set 4 CR -1 03/15/24, 10:43

    Reply

    Thanks - will have a look later and finish it than.
  12. Stefan Bürk uploaded patch set 5 CR -1 V +1 04/04/24, 14:51

  13. core-ci voted on patch set 5 V +1 04/04/24, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55337

  14. Stefan Bürk commented on patch set 5 04/04/24, 14:58

    Reply

    Done
  15. Oliver Hader commented on patch set 5 04/04/24, 15:11

    What do you think about removing the data-handler test case and add a specific one in the `LinkHandling` layer instead?
  16. Stefan Bürk commented on patch set 5 04/04/24, 22:51

    Reply

    I'd like to keep that for redirects specific. Will look tomorrow into LinkHandling related tests to add additional ones in that layer directly.
  17. Stefan Bürk uploaded patch set 6 V +1 04/05/24, 10:42

  18. Stefan Bürk updated the commit message in patch set 7 04/05/24, 10:45

  19. core-ci voted on patch set 6 V -1 04/05/24, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55377

  20. core-ci voted on patch set 7 V -1 04/05/24, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55378

  21. Stefan Bürk uploaded patch set 8 V -1 04/05/24, 10:53

  22. core-ci voted on patch set 8 V +1 04/05/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55379

  23. Stefan Bürk commented on patch set 8 04/05/24, 11:03

    Reply

    Done
  24. Stefan Bürk uploaded patch set 9 V +1 04/05/24, 11:06

  25. core-ci voted on patch set 9 V +1 04/05/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55380

  26. Simon Schaufelberger commented on patch set 9 04/08/24, 23:24

    the TYPO3... allows
    try or attempt but not both.
    grammatically totally not correct

    SlugServiceTest.php:582

    this line is probably not necessary as the phpstorm meta file annotates it.

    SlugServiceTest.php:586

    this line is probably not necessary as the phpstorm meta file annotates it.
  27. Stefan Bürk commented on patch set 9 04/10/24, 15:05

    SlugServiceTest.php:582 Reply

    For the datahandler below it did not work. It `seems` to work for this, albeit I cannot say if the dropdown list is complete. Will remove this one.

    SlugServiceTest.php:586 Reply

    I needed it because PHPStorm not correctly listing availalbe propeties and methods, despite the metafile. I checked the file, but don't invested much time. Can be removed but does not hurt - so keep it for now. And still not working. However, will remove it as it is complete now and can be readded if needed or PHPStorm fixed. Note: In my case $dataHandler-> only shows the `setLogger` method and nothing else.
  1. Stefan Bürk uploaded patch set 10 V +1 04/10/24, 15:13

  2. Stefan Bürk commented on patch set 10 04/10/24, 15:13

    Reply

    Done

    Reply

    Done

    Reply

    Done

    SlugServiceTest.php:582 Reply

    Done

    SlugServiceTest.php:586 Reply

    Done
  3. core-ci voted on patch set 10 V +1 04/10/24, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55692

  4. Simon Schaufelberger updated the commit message in patch set 11 V +1 04/10/24, 15:42

  5. Simon Schaufelberger voted on patch set 11 CR +1 04/10/24, 15:44

  6. core-ci voted on patch set 11 V +1 04/10/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55694

  7. Stefan Bürk commented on patch set 11 CR -1 04/10/24, 17:56

    @simonschaufi+typo3@gmail.com thanks for adjusting the commit message. Please ensure to not exceed maximum line length for commit message lines during such actions -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/83444/10..11//COMMIT_MSG Will push again shortly to fix them.
  8. Stefan Bürk uploaded patch set 12 CR +1 V +1 04/10/24, 17:57

  9. Stefan Bürk commented on patch set 12 04/10/24, 17:57

    Reply

    Done
  10. Simon Schaufelberger commented on patch set 12 04/10/24, 17:58

    Reply

    I have actually edited the commit message right here and ci is green so I was not aware of the problem.
  11. core-ci voted on patch set 12 V +1 04/10/24, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55704

  12. Stefan Bürk commented on patch set 12 04/10/24, 18:45

    Reply

    Done
  13. Markus Klein voted on patch set 12 CR +1 04/17/24, 08:32

  14. Stephan Großberndt updated the commit message in patch set 13 CR +1 V +1 04/19/24, 16:11

  15. core-ci voted on patch set 13 V +1 04/19/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56347

  16. Markus Klein voted on patch set 13 CR +1 04/20/24, 05:11

  17. Markus Klein voted on patch set 13 V +1 04/20/24, 05:12

  18. Simon Schaufelberger voted on patch set 13 CR +1 04/20/24, 12:18

  19. Stefan Bürk updated the commit message in patch set 14 CR +1 V +1 04/20/24, 12:35

  20. core-ci voted on patch set 14 V +1 04/20/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56384

  21. Simon Schaufelberger voted on patch set 14 CR +1 04/20/24, 13:30

  22. Markus Klein voted on patch set 14 CR +1 V +1 04/20/24, 17:13

  23. Benni Mack voted on patch set 14 CR +1 V +1 04/21/24, 09:51

  24. Stefan Bürk voted on patch set 14 CR +2 V +2 04/21/24, 11:36

  25. Stefan Bürk merged patch set 15 04/21/24, 11:48