83444[BUGFIX] Ensure that relative target link can be set in EXT:redirects
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Markus Klein +1
- Simon Schaufelberger +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Markus Klein +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+6 −6
- typo3/sysext/core/Tests/Functional/LinkHandling/Fixtures/fileadmin/some/path/typo3-logo.pngnewbinary
- typo3/sysext/core/Tests/Functional/LinkHandling/LegacyLinkNotationConverterTest.phpnew+94 −0
- typo3/sysext/core/Tests/Functional/LinkHandling/LinkServiceTest.phpnew+66 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/AssertionDataSets/RelativeTargetDataHandler.csvnew+6 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RelativeTargetDataHandler.csvnew+3 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php6+33 −0
Review log 3852
Show 1827 earlier messages
-
Stefan Bürk uploaded patch set 1 03/12/24, 14:45
-
core-ci voted on patch set 1 V +1 03/12/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54437
-
Stefan Bürk uploaded patch set 2
V +103/13/24, 09:53 -
core-ci voted on patch set 2 V +1 03/13/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54465
-
Stefan Bürk uploaded patch set 3
V +103/13/24, 11:19 -
core-ci voted on patch set 3 V +1 03/13/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54470
-
Oliver Hader commented on patch set 3 CR -1 03/15/24, 09:55
The problem is not in `DataHandler`... -
Oliver Hader uploaded patch set 4
CR -1V +103/15/24, 10:04 -
core-ci voted on patch set 4 V +1 03/15/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54574
-
Oliver Hader commented on patch set 4 03/15/24, 10:40
@Stefan: After investigating, I've added some notes to https://forge.typo3.org/issues/103387#note-4 > **tl;dr: Using arbitrary (non-FAL) resources did not work before, there was no regression.** I'm leaving the rest of this patch to you. Just let me know in case you need additional feedback or support. Thx! 👍 -
Stefan Bürk commented on patch set 4 CR -1 03/15/24, 10:43
Reply
Thanks - will have a look later and finish it than. -
Stefan Bürk uploaded patch set 5
CR -1V +104/04/24, 14:51 -
core-ci voted on patch set 5 V +1 04/04/24, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55337
-
Stefan Bürk commented on patch set 5 04/04/24, 14:58
Reply
Done -
Oliver Hader commented on patch set 5 04/04/24, 15:11
What do you think about removing the data-handler test case and add a specific one in the `LinkHandling` layer instead? -
Stefan Bürk commented on patch set 5 04/04/24, 22:51
Reply
I'd like to keep that for redirects specific. Will look tomorrow into LinkHandling related tests to add additional ones in that layer directly. -
Stefan Bürk uploaded patch set 6
V +104/05/24, 10:42 -
Stefan Bürk updated the commit message in patch set 7 04/05/24, 10:45
-
core-ci voted on patch set 6 V -1 04/05/24, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55377
-
core-ci voted on patch set 7 V -1 04/05/24, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55378
-
Stefan Bürk uploaded patch set 8
V -104/05/24, 10:53 -
core-ci voted on patch set 8 V +1 04/05/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55379
-
Stefan Bürk commented on patch set 8 04/05/24, 11:03
Reply
Done -
Stefan Bürk uploaded patch set 9
V +104/05/24, 11:06 -
core-ci voted on patch set 9 V +1 04/05/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55380
-
Simon Schaufelberger commented on patch set 9 04/08/24, 23:24
the TYPO3... allowstry or attempt but not both.grammatically totally not correctSlugServiceTest.php:582this line is probably not necessary as the phpstorm meta file annotates it.SlugServiceTest.php:586this line is probably not necessary as the phpstorm meta file annotates it. -
Stefan Bürk commented on patch set 9 04/10/24, 15:05
SlugServiceTest.php:582ReplyFor the datahandler below it did not work. It `seems` to work for this, albeit I cannot say if the dropdown list is complete. Will remove this one.SlugServiceTest.php:586ReplyI needed it because PHPStorm not correctly listing availalbe propeties and methods, despite the metafile. I checked the file, but don't invested much time. Can be removed but does not hurt - so keep it for now. And still not working. However, will remove it as it is complete now and can be readded if needed or PHPStorm fixed. Note: In my case $dataHandler-> only shows the `setLogger` method and nothing else.
-
Stefan Bürk uploaded patch set 10
V +104/10/24, 15:13 -
Stefan Bürk commented on patch set 10 04/10/24, 15:13
Reply
DoneReply
DoneReply
DoneSlugServiceTest.php:582ReplyDoneSlugServiceTest.php:586ReplyDone -
core-ci voted on patch set 10 V +1 04/10/24, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55692
-
Simon Schaufelberger updated the commit message in patch set 11
V +104/10/24, 15:42 -
Simon Schaufelberger voted on patch set 11 CR +1 04/10/24, 15:44
-
core-ci voted on patch set 11 V +1 04/10/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55694
-
Stefan Bürk commented on patch set 11 CR -1 04/10/24, 17:56
@simonschaufi+typo3@gmail.com thanks for adjusting the commit message. Please ensure to not exceed maximum line length for commit message lines during such actions -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/83444/10..11//COMMIT_MSG Will push again shortly to fix them. -
Stefan Bürk uploaded patch set 12
CR +1V +104/10/24, 17:57 -
Stefan Bürk commented on patch set 12 04/10/24, 17:57
Reply
Done -
Simon Schaufelberger commented on patch set 12 04/10/24, 17:58
Reply
I have actually edited the commit message right here and ci is green so I was not aware of the problem. -
core-ci voted on patch set 12 V +1 04/10/24, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55704
-
Stefan Bürk commented on patch set 12 04/10/24, 18:45
Reply
Done -
Markus Klein voted on patch set 12 CR +1 04/17/24, 08:32
-
Stephan Großberndt updated the commit message in patch set 13
CR +1V +104/19/24, 16:11 -
core-ci voted on patch set 13 V +1 04/19/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56347
-
Markus Klein voted on patch set 13 CR +1 04/20/24, 05:11
-
Markus Klein voted on patch set 13 V +1 04/20/24, 05:12
-
Simon Schaufelberger voted on patch set 13 CR +1 04/20/24, 12:18
-
Stefan Bürk updated the commit message in patch set 14
CR +1V +104/20/24, 12:35 -
core-ci voted on patch set 14 V +1 04/20/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56384
-
Simon Schaufelberger voted on patch set 14 CR +1 04/20/24, 13:30
-
Markus Klein voted on patch set 14 CR +1 V +1 04/20/24, 17:13
-
Benni Mack voted on patch set 14 CR +1 V +1 04/21/24, 09:51
-
Stefan Bürk voted on patch set 14 CR +2 V +2 04/21/24, 11:36
-
Stefan Bürk merged patch set 15 04/21/24, 11:48