Review 12.4 Merged

83446[BUGFIX] Add server request to view in ConfirmationFinisher

Oli Bartsch CR +2 V +2 Easy +3 −7 updated 03/12/24, 17:23

Commit message

Since #98377 it is not possible to use `f:link.page`
ViewHelper in the ConfirmationFinisher template.

This adds the server request to the standalone view
to make it work again.

Also removed wrong comment and direct usage of global
request object.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 35

  1. Oli Bartsch uploaded patch set 1 03/12/24, 17:15

  2. core-ci voted on patch set 1 V -1 03/12/24, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54441

  3. core-ci voted on patch set 1 V +1 03/12/24, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54441

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 03/12/24, 17:23

  5. Oli Bartsch merged patch set 2 03/12/24, 17:23