Review main Merged

83450[BUGFIX] Recalculate context-menu position after data population

Benjamin Franzke CR +2 V +2 Easy +13 −6 updated 03/13/24, 14:10

Commit message

With #103197, a loading indicator was added to the context menus,
which rendered a stub context-menu.
The position of the context-menu needs to be recalculated once the
data has been loaded (the context-menu becomes taller) in order to
avoid rendering outside the visible window area.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Kevin Appelt +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Sven Juergens +1
    • Kevin Appelt +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 67

  1. Benjamin Franzke uploaded patch set 1 03/13/24, 09:24

  2. core-ci voted on patch set 1 V +1 03/13/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54462

  3. Sven Juergens voted on patch set 1 V +1 03/13/24, 09:32

  4. Kevin Appelt voted on patch set 1 CR +1 V +1 03/13/24, 09:41

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 03/13/24, 10:28

  6. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/13/24, 13:41

  7. Benjamin Franzke merged patch set 2 03/13/24, 14:10