Review main Abandoned

83452[BUGFIX] Free up horizontal space in page module

Ayke Halder CR 0 V 0 Easy +19 −17 updated 07/18/24, 10:37

Commit message

The content of the page module uses more of the given page width. This
is a benefit for multi-column page-layouts.

Before there was a gray border and white spacing surrounding the whole
content area.

This patch ensures that horizontal scrolling of the column-grid on
small-screen-devices is still working and visual appealing.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1013

  1. Ayke Halder uploaded patch set 1 03/13/24, 11:53

  2. core-ci voted on patch set 1 V +1 03/13/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54472

  3. Ayke Halder uploaded patch set 2 V +1 03/14/24, 15:44

  4. core-ci voted on patch set 2 V +1 03/14/24, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54544

  5. Simon Schaufelberger commented on patch set 2 07/12/24, 00:20

    Is this still relevant and if so, can you please rebase?
  6. Christian Rath-Ulrich voted on patch set 2 CR +1 V +1 07/17/24, 15:15

  7. Benjamin Kott commented on patch set 2 CR -1 07/18/24, 06:48

    merge conflict
  8. Ayke Halder uploaded patch set 3 CR +1 V +1 07/18/24, 08:19

  9. core-ci voted on patch set 3 V +1 07/18/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61732

  10. Ayke Halder commented on patch set 3 07/18/24, 08:42

    Reply

    Done
    Rebased.
  11. Ayke Halder commented on patch set 3 V -1 07/18/24, 10:18

    I'd actually abandon this in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83672 * This one here removes the spacing and the gray line. * The other one just outdents the spacing and line - thereby the effect of gaining horizontal space is the same.
  12. Benjamin Kott commented on patch set 3 07/18/24, 10:36

    Reply

    ack, ill abandon it now
  13. Benjamin Kott abandoned the change 07/18/24, 10:37