Review main Merged

83455[BUGFIX] Prevent TypeErrors in FormEngine for missing elements

Oli Bartsch CR +2 V +2 Easy +16 −4 updated 03/16/24, 09:17

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1115

  1. Oli Bartsch uploaded patch set 1 03/13/24, 15:22

  2. core-ci voted on patch set 1 V +1 03/13/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54485

  3. Andreas Kienast uploaded patch set 2 V +1 03/13/24, 15:31

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 03/13/24, 15:32

  5. core-ci voted on patch set 2 V +1 03/13/24, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54486

  6. Oli Bartsch uploaded patch set 3 CR +1 V +1 03/13/24, 15:51

  7. Andreas Kienast commented on patch set 4 03/13/24, 15:53

    Published edit on patch set 3.
  8. Andreas Kienast voted on patch set 4 CR +1 V +1 03/13/24, 15:54

  9. core-ci voted on patch set 3 V +1 03/13/24, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54487

  10. core-ci voted on patch set 4 V +1 03/13/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54488

  11. Christian Kuhn commented on patch set 4 03/14/24, 06:31

    How to reproduce? There is no information on this in the patch nor in the issue?
  12. Andreas Kienast commented on patch set 4 03/14/24, 06:51

    Reply

    Good point. This can be tested in combination with the meanwhile merged https://review.typo3.org/c/Packages/TYPO3.CMS/+/83458.
  13. Jochen Roth voted on patch set 4 CR +1 V +1 03/15/24, 16:07

  14. Oli Bartsch commented on patch set 4 CR +2 V +2 03/16/24, 09:17

    Reply

    Done
  15. Oli Bartsch merged patch set 5 03/16/24, 09:17