83456[DOCS] Add important RST for changed form framework markup
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Chris Müller +1
-
Verified V +2 Done
- Oli Bartsch +2
- Chris Müller +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1521
-
Kevin Appelt uploaded patch set 1 03/13/24, 16:12
-
Oli Bartsch updated the commit message in patch set 2 03/13/24, 16:15
-
Mathias Brodala commented on patch set 2 03/13/24, 16:17
-
core-ci voted on patch set 1 V +1 03/13/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54489
-
Oli Bartsch uploaded patch set 3 03/13/24, 16:20
-
core-ci voted on patch set 2 V +1 03/13/24, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54490
-
Oli Bartsch uploaded patch set 4 03/13/24, 16:21
-
Oli Bartsch commented on patch set 4 CR +1 V +1 03/13/24, 16:21
Important-103117-FormFrameworkSelectMarkupChanged.rst:16ReplyDone -
core-ci voted on patch set 3 V +1 03/13/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54491
-
core-ci voted on patch set 4 V +1 03/13/24, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54492
-
Garvin Hicking commented on patch set 4 03/13/24, 16:29
Important-103117-FormFrameworkSelectMarkupChanged.rst:24I believe an extra newline must be added here for correct rendering (can't verify, am on mobile) -
Stefan Bürk commented on patch set 5
CR +1V +103/13/24, 16:39Published edit on patch set 4. -
Stefan Bürk commented on patch set 5 CR +1 V +1 03/13/24, 16:39
Important-103117-FormFrameworkSelectMarkupChanged.rst:24ReplyDone -
core-ci voted on patch set 5 V +1 03/13/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54495
-
Chris Müller commented on patch set 5 CR -1 03/13/24, 17:28
on it -
Chris Müller uploaded patch set 6
CR +1V +103/13/24, 18:02 -
Chris Müller commented on patch set 6 CR +1 V +1 03/13/24, 18:04
Reply
Emphasizes lines for better reception of the change. Also removed the superfluous namespace (see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Important-97517-RemoveTheSuperfluousNamespaceWithinTheFormConfiguration.html) -
core-ci voted on patch set 6 V +1 03/13/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54498
-
Oli Bartsch voted on patch set 6 CR +1 V +1 03/13/24, 18:22
-
Oli Bartsch voted on patch set 6 CR +2 V +2 03/13/24, 18:22
-
Oli Bartsch merged patch set 7 03/13/24, 18:22
Important-103117-FormFrameworkSelectMarkupChanged.rst:16