83457[BUGFIX] Ensure `Comparator` knows the current platform
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Developer Archriss +1
- Garvin Hicking +1
- Christophe Monard +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Developer Archriss +1
- Garvin Hicking +1
- Christophe Monard +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1418
-
Stefan Bürk uploaded patch set 1 03/13/24, 16:34
-
Stefan Bürk uploaded patch set 2 03/13/24, 16:37
-
core-ci voted on patch set 1 V +1 03/13/24, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54493
-
core-ci voted on patch set 2 V +1 03/13/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54494
-
core-ci commented on patch set 2 03/13/24, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54496
-
Stefan Bürk uploaded patch set 3
V +103/14/24, 10:49 -
core-ci voted on patch set 3 V +1 03/14/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54523
-
Stefan Bürk commented on patch set 3 03/14/24, 10:57
Note: Nightly with more database vendors testing was happy ;) -
Stefan Bürk voted on patch set 3 CR -1 03/14/24, 11:18
-
Garvin Hicking commented on patch set 3 03/14/24, 11:19
(verified working in DB analyzer with text changes, waiting for feedback on PermissionCheck platform injection neccessity to give a vote) -
Stefan Bürk voted on patch set 3 CR 0 03/14/24, 11:24
-
Stefan Bürk commented on patch set 3 03/14/24, 11:27
Reply
Note: In main(v13) along with Doctrine DBAL 4 it was required to change the PermissionCheck and use the comparator directly there, but does not matter here for this change because of ... * v12 does not use it directly in PermissionCheck * v13 with Doctrine DBAL 4 uses `compareSchemas()`, but the dbal deprecation layer from static to non-static is not included and no longer creating a instance - which means the platform is set and not missed. That are the points why only v12 is target by this issue, and the fix needs to go only into v12. -
Garvin Hicking voted on patch set 3 CR +1 V +1 03/14/24, 11:27
-
Christophe Monard commented on patch set 3 CR +1 V +1 03/15/24, 08:16
Work on v12 instance for me. Thanks -
Christian Kuhn voted on patch set 3 CR +1 V +1 03/19/24, 12:25
-
Developer Archriss voted on patch set 3 CR +1 V +1 03/19/24, 12:46
-
Stefan Bürk voted on patch set 3 CR +2 V +2 03/19/24, 13:08
-
Stefan Bürk merged patch set 4 03/19/24, 13:08